Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented comments on my previous pull request (unified thick tracking for combined function dipole) #471

Merged
merged 2 commits into from Sep 29, 2017

Conversation

alatina
Copy link
Contributor

@alatina alatina commented Sep 29, 2017

  • changed subroutine's title ("cosmetic" change)
  • changed declaration of double precision complex to conform to other parts of the code

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.797% when pulling 75656f0 on alatina:master into 1a64dca on MethodicalAcceleratorDesign:master.

Copy link
Contributor

@ldeniau ldeniau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it would be better to restore the ttquad map for pure quadrupole and use ttcfd as a combined sbend only. It will make the quad simpler and faster, and available for crosscheck with ttcfd(k0=0)!

Copy link
Contributor

@ldeniau ldeniau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intermediate state approved.

@ldeniau ldeniau merged commit ca6bf17 into MethodicalAcceleratorDesign:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants