save sequence with patterns crashes

[ldeniau]

Reported by Androula:

Saving a sequence with SELECTed pattern leads to a segfault in pass_select_el
I found the missing guard in the new function pass_select_el

    if (el != NULL) {
      if(myregex(pattern, strip(el->name)) == 0) in = 1;
    }

But in fact this function should never work on NULL element... Some check and redirection is missing in pass_select when the element is not found.

BUT once the guard was added, I discovered that SELECT flag=save is not anymore saving variables! The changes from Thomas are significant so it is difficult to follow the intent of all the changes. Another concern is the selection of columns and rows in tables, and the mechanism of FILL and SETVARSs that use variables.

Laurent.

[ldeniau]

added files from Androula.
androula.zip

[ldeniau]

here is what we should save in file newsps_thinstr.str with patterns (from 5.03.06)

kqd = -0.01395887281;
kqda := kqd*9.0/11.0;
kqf1 = 0.01395627532;
kqf1a := kqf1*9.0/11.0;
kqf2 := kqf1;
kqf2a := kqf2*9.0/11.0;
kqe11402 = 0;
kqms = 0;
kqe30202 = 0;
kqecd30602 = 0;
kqecd31402 = 0;
kqe50202 = 0;
kqe51402 = 0;
kqecd53402 = 0;
kqe60302 = 0;
kqe60402 = 0;
kqe60502 = 0;
kqe60602 = 0;
kmkqh11653 = 0;
kmkqv11679 = 0;
mkqh: hkicker,l:= 0,lrad:= 0;
mkqh.11653: mkqh,lrad:= 0,kick:=kmkqh11653 ,slot_id:= 2362089;
mkqv: vkicker,l:= 0,lrad:= 0;
mkqv.11679: mkqv,lrad:= 0,kick:=kmkqv11679 ,slot_id:= 2362096;

and here is what is actually saved (from 5.03.07)

mkqh: hkicker,l:= 0,lrad:= 0;
mkqh.11653: mkqh,lrad:= 0,kick:=kmkqh11653 ,slot_id:= 2362089;
mkqv: vkicker,l:= 0,lrad:= 0;
mkqv.11679: mkqv,lrad:= 0,kick:=kmkqv11679 ,slot_id:= 2362096;

So all the variables that fulfil the pattern are not saved.