Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double survey messes the comments #787

Closed
rdemaria opened this issue Jun 19, 2019 · 2 comments
Closed

double survey messes the comments #787

rdemaria opened this issue Jun 19, 2019 · 2 comments
Assignees
Labels
bug the behaviour is not documented and should be fixed in the code

Comments

@rdemaria
Copy link
Contributor

option, -echo, warn, info;
m1:marker,comments=fafdadfaf;
ss: sequence,l=10;
m1,at=4;
endsequence;
beam;
use,sequence=ss;survey; survey;
show,m1;

  ++++++++++++++++++++++++++++++++++++++++++++
  +     MAD-X 5.05.01  (64 bit, Linux)       +
  + Support: mad@cern.ch, http://cern.ch/mad +
  + Release   date: 2019.06.07               +
  + Execution date: 2019.06.19 19:19:57      +
  ++++++++++++++++++++++++++++++++++++++++++++
option, -echo, warn, info;

+++ dumping element m1                  parent marker            
command: m1  module: element
....
parameter: comments   string: ss$start:1

  Number of warnings: 0

  ++++++++++++++++++++++++++++++++++++++++++++
  +          MAD-X finished normally         +
  ++++++++++++++++++++++++++++++++++++++++++++

@ldeniau ldeniau added the bug the behaviour is not documented and should be fixed in the code label Jun 19, 2019
@tpersson
Copy link
Contributor

Just ran the example and can see the problem and I also notice that the same thing does not happen when doing two TWISS. I will have a look inside the code now to see what the problem might be.

madcern added a commit that referenced this issue Jun 24, 2019
Fixes the problem (#787) that several survey changes the comments.
@madcern
Copy link
Contributor

madcern commented Jun 24, 2019

Thanks for reporting this and also the clear minimalistic example showing the issue! It made it much easier to debug. The bug is fixed in #788 .

@madcern madcern closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the behaviour is not documented and should be fixed in the code
Projects
None yet
Development

No branches or pull requests

4 participants