Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to set colors above index 15 with OSC 4 #313

Closed
zadjii-msft opened this issue Nov 26, 2018 · 5 comments
Closed

Unable to set colors above index 15 with OSC 4 #313

zadjii-msft opened this issue Nov 26, 2018 · 5 comments
Assignees
@zadjii-msft
Labels
Area-VT Virtual Terminal sequence support Product-Conhost For issues in the Console codebase Resolution-Fix-Available It's available in an Insiders build or a release Work-Item It's being tracked by an actual work item internally. (to be removed soon)
Milestone
19H1

Comments

@zadjii-msft
Copy link
Member

From #81:

Conhost doesn't support setting color table entries above 130.

Here's xterm printing in 130 by default:
image

I couldn't get the syntax just right, but for example, you definitely can change the colors of the extended table:
image
Note how color 130 is now a black square, instead of the color it usually is
@zadjii-msft zadjii-msft added the Product-Conhost For issues in the Console codebase label Nov 26, 2018
@zadjii-msft zadjii-msft added this to the 19H1 milestone Nov 26, 2018
@zadjii-msft zadjii-msft self-assigned this Nov 26, 2018
@zadjii-msft
Copy link
Member Author

MSFT:19723934

@zadjii-msft zadjii-msft added the Work-Item It's being tracked by an actual work item internally. (to be removed soon) label Nov 26, 2018
@zadjii-msft zadjii-msft mentioned this issue Nov 26, 2018
Closed
@Jaykul Jaykul mentioned this issue Dec 6, 2018
Closed
@zadjii-msft zadjii-msft added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 10, 2019
@miniksa miniksa added Area-VT Virtual Terminal sequence support Resolution-Fix-Available It's available in an Insiders build or a release and removed Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Jan 18, 2019
@miniksa
Copy link
Member

miniksa commented Jan 18, 2019

I checked this morning and this fix should be in Insiders builds 18312 and higher (build on or after 2019-01-04).

@miniksa miniksa closed this as completed Jan 18, 2019
@DHowett-MSFT
Copy link
Contributor

This one's a little funny, actually. Most of the fix is in 18312, but it'll only work for colors 0-99. Colors 100-255 will probably be in whatever insider build comes next.

@miniksa miniksa reopened this Jan 18, 2019
@miniksa
Copy link
Member

miniksa commented Jan 18, 2019

Yes, sorry, this one had two changelists on it. It's also inbound.

@miniksa miniksa added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 18, 2019
@DHowett-MSFT DHowett-MSFT removed the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 8, 2019
@DHowett-MSFT
Copy link
Contributor

This is now fully supported as of insider's build 18334.

@Woodham Woodham mentioned this issue Feb 18, 2019
Closed
@egmontkob egmontkob mentioned this issue Nov 26, 2019
Closed
@zadjii-msft zadjii-msft mentioned this issue Nov 26, 2019
Open
7 tasks
@WSLUser WSLUser mentioned this issue Jun 2, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-VT Virtual Terminal sequence support Product-Conhost For issues in the Console codebase Resolution-Fix-Available It's available in an Insiders build or a release Work-Item It's being tracked by an actual work item internally. (to be removed soon)
Projects
None yet
Milestone
19H1
Development

No branches or pull requests
3 participants
@DHowett-MSFT @miniksa @zadjii-msft