Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in activation function ONES_COMPLIMENT? #5

Open
guillaumecherel opened this issue Jul 9, 2015 · 1 comment
Open

error in activation function ONES_COMPLIMENT? #5

guillaumecherel opened this issue Jul 9, 2015 · 1 comment

Comments

@guillaumecherel
Copy link

I was reading your code to see what activation functions were used and noticed that the computation of activation function ONES_COMPLIMENT (e.g. in files NEAT_FractalNetwork.cpp
and NEAT_FastNetwork.cpp, and may be others) contains the following lines where the second overrides the result of the first, which looks like an error. Should there be another variable instead of retVal on the first line?

(line 839) retVal = max(0.0,tmpVal2);  
(line 840) retVal = 1.0-tmpVal2;
@MisterTea
Copy link
Owner

Yeah I think it should be tmpVal2 = max(0.0, tmpVal2). Can you fix and submit a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants