Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in RepositoriesEndPoint.GetDiff() and GetPatch()? #93

Open
asherber opened this issue Dec 20, 2018 · 3 comments
Open

Bug in RepositoriesEndPoint.GetDiff() and GetPatch()? #93

asherber opened this issue Dec 20, 2018 · 3 comments

Comments

@asherber
Copy link
Contributor

I came across this while working on #90 .

Both GetDiff() and GetPatch() take an options parameter which is an object. Looking at the API here and here I think this parameter should be called spec and should just be a string; passing in a random object will cause errors.

In addition, GetDiff() should be able to take an object like ListParameters that provides context, path, ignore_whitespace, and binary.

I can put together a PR if you agree that these should be fixed.

@MitjaBezensek
Copy link
Owner

I'm all for supporting more API calls 👍 I think that these names changed while the API evolved, thus the wrong names.

@asherber
Copy link
Contributor Author

I've got this coded, but I'm waiting on a response from Bitbucket support. The docs say that the path parameter "can be repeated for multiple paths", but I can't seem to get that to work in Postman. If I send multiple path parameters, only the last one has any effect, and sending comma or semicolon delimited values doesn't work either. I want to see if this is an error in the docs, or a bug in the API, or if there's some other way of sending multiple paths.

@asherber
Copy link
Contributor Author

Still going back and forth with Bitbucket support. They have acknowledged that there are some problems on their side; they said they put a fix in, but it's still not working as advertised for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants