Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test commands #21

Open
nkrusch opened this issue Jan 14, 2021 · 1 comment
Open

Unit test commands #21

nkrusch opened this issue Jan 14, 2021 · 1 comment
Labels
dev-tasks workflow, refactor and dev-ops related

Comments

@nkrusch
Copy link
Contributor

nkrusch commented Jan 14, 2021 •
edited

Is your feature request related to a problem? Please describe.

Yes -- adding testing to these commands would give more confidence in not breaking them on changes.

Issue is these commands perform IO so they are not straightforward to test. Looking for examples.
@nkrusch nkrusch added the enhancement New feature or request label Jan 14, 2021
@nkrusch nkrusch mentioned this issue Jan 14, 2021
Closed
2 tasks
nkrusch added a commit that referenced this issue Jan 14, 2021
@nkrusch
#21: add starter code
56c2a7b
@nkrusch nkrusch changed the title Unit test Commands Unit test commands Jan 30, 2021
@nkrusch nkrusch added dev-tasks workflow, refactor and dev-ops related and removed enhancement New feature or request labels Jul 19, 2021
@nicolas377
Copy link
Collaborator

What you're probably looking for is an end to end test. This can still be achieved with sinon. It'll probably take a while to get e2e tests running though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-tasks workflow, refactor and dev-ops related
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkrusch @nicolas377