Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify Mobility Database workflow so when new validator version is released, run the validator on all latest datasets #428

Merged
merged 9 commits into from
May 27, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented May 14, 2024

Summary:

Closes issue #1746. This PR introduces functionality to run an update of the validation report when the GTFS Canonical Validator Web Services are updated.

Expected Behavior:

  • When the staging environment of the web services is updated, a Cloud Task is created in the dev project within the update-validation-report queue, set to run 24 hours after the trigger.
  • When the GTFS Validator is released, the same process is followed in the production environment.

Working example from dev:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as ready for review May 14, 2024 23:50
Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y
Copy link
Contributor Author

cka-y commented May 16, 2024

Merging this after QA testing is completed

Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y cka-y merged commit 1b9bff0 into main May 27, 2024
2 checks passed
@cka-y cka-y deleted the feat/validator/1746 branch May 27, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants