Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foreign_key_violation doesn't catch a missing trip_id #1752

Open
tzujenchanmbd opened this issue May 9, 2024 · 3 comments
Open

foreign_key_violation doesn't catch a missing trip_id #1752

tzujenchanmbd opened this issue May 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues

Comments

@tzujenchanmbd
Copy link

tzujenchanmbd commented May 9, 2024

Describe the bug

When testing a feed with GTFS-flex data where there is a missing trip_id in trip.txt(parent file) but being referenced in stop_times.txt, validator doesn't show a foreign_key_violation error.

Here is the report link:
https://gtfs-validator-results.mobilitydata.org/83a0d446-3a65-4258-92c1-22b61c5dd6fe/report.html

Steps/Code to Reproduce

  1. Download the test feed provided below
  2. Upload the feed to Canonical GTFS Schedule Validator

Expected Results

Validator shows a foreign_key_violation error that indicates trip_id=t_5298041_b_77503_tn_0 in stop_times.txt cannot be found in trips.txt.

Actual Results

Validator doesn't show the error

Screenshots

No response

Files used

on-demand_services_between_multiple_zones.zip

Validator version

5.0.1

Operating system

MacOS

Java version

No response

Additional notes

No response

@tzujenchanmbd tzujenchanmbd added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues labels May 9, 2024
Copy link

welcome bot commented May 9, 2024

Thanks for opening your first issue in this project! If you haven't already, you can join our slack and join the #gtfs-validators channel to meet our awesome community. Come say hi 👋!

Welcome to the community and thank you for your engagement in open source! 🎉

@emmambd emmambd added this to the Flex: modifying pre-existing rules milestone May 14, 2024
@qcdyx
Copy link
Contributor

qcdyx commented May 16, 2024

image I got too deep into analyzing the issue—it actually stems from a parsing error in the stop_times.txt file. Let's delve into how we can improve the presentation of this error for our end users.

@qcdyx
Copy link
Contributor

qcdyx commented May 21, 2024

3 of the Flex gtfs data sets got parsing issues listed here https://docs.google.com/document/d/1QABoIeOdR6lAB7A6_X6WIbZwC7EnAIZvm_hRNwNQeoI/edit#heading=h.xt9phhoxqouq
New issue created #1767

@emmambd emmambd modified the milestones: Flex: modifying pre-existing rules, 6.0 Validator Release May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues
Projects
Status: Requires investigation
Development

No branches or pull requests

3 participants