Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexedDB test crashes with a security error when running in iframe on Safari because open test isn't wrapped in try-catch #2586

Open
stretch327 opened this issue Jul 19, 2020 · 3 comments
Open

IndexedDB test crashes with a security error when running in iframe on Safari because open test isn't wrapped in try-catch #2586

stretch327 opened this issue Jul 19, 2020 · 3 comments

Comments

@stretch327
Copy link

stretch327 commented Jul 19, 2020 •
edited

The IndexedDB test uses a try-catch to test if indexedDB is available on window, but then does not wrap the call to the open method which fails. I've taken a screenshot of the place where it fails. This fails on Safari when inside an iframe because Safari doesn't allow it.
indexedDB_fail
@Markel
Copy link
Contributor

Markel commented Jul 22, 2020

Hi Greg 👋! Thanks for informing, I guess we could move the check inside the try? But I'm not sure, I'm not very familiar with the IndexedDB test 🤔. Moreover I don't have a Mac (or iPhone) so if you are open to submit a PR it would be very welcomed!

@Xenonym
Copy link
Contributor

Xenonym commented Oct 5, 2020

Shouldn't this have been resolved by #2336?

@rejas
Copy link
Member

rejas commented Oct 6, 2020

Maybe @stretch327 can comment on that? What version were you using? Something >= 3.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rejas @Xenonym @stretch327 @Markel