Codecov Report

Merging #2593 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2593   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files           5        5           
  Lines         165      165           
=======================================
  Hits          157      157           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f3f36...737279a. Read the comment docs.

Lgtm 😄 as long as making it async doesn't make it backwards incompatible as we discussed in #2590 (which I doubt it but better to be sure than sorry).

The only thing is that inside the else comment (line 43) it would be nice to explain that the test doesn't work if we are inside a iframe:none and that is why we wait. Simply adding a #2590 will probably be enough for people in the future to find out the reasoning.

@Markel good idea, I just pushed a comment linking to the issue

Re: backwards compatibility. I think the only way this would break compatibility is if they use Modernizr.flexgap during page load. Rather than returning false it would be undefined.

To potentially avoid this, we could adapt the test to be sync under normal circumstances and only be async if it detects it is inside a display:none iframe. However, this would still have the issue of Modernizr.flexgap not working under the async case. Also not sure if it is acceptable to have the async/sync nature switch out depending on runtime conditions.

Or if there is some way to remove my setTimeout() call, that would be ideal as I think it would support using Modernizr.flexgap during page load, even though it is technically an async test.

I don't really know how to contribute in here, I don't really know. Maybe @rejas knows better :)

Maybe we should get back to this? 👀

definitly. maybe @patrickkettner can take a look to :-) ?