Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exif orientation test incorrectly returns false in iOS Safari version 13.3 and below #2615

Open
1 of 4 tasks
OliverJAsh opened this issue Nov 17, 2020 · 3 comments
Open
1 of 4 tasks
Labels
caniuse modernizr tests differ from caniuse results

Comments

@OliverJAsh
Copy link
Contributor

OliverJAsh commented Nov 17, 2020

Type of bug

  • Differences between Can I use & Modernizr
  • False positive
  • False negative
  • Modernizr error

Describe the bug

The Exif orientation test returns false in iOS Safari 13.3 and below.

How to Reproduce
https://stackblitz.com/edit/js-rq1mxv?file=index.html
or
https://stackblitz.com/edit/feature-detect-img-orientation-uyxm7k?file=index.ts

Expected behavior
It should return true.

Additional context
iOS Safari only honours Exif orientation if the element has been added to the DOM and it is visible. Here is a test that works: https://stackblitz.com/edit/feature-detect-img-orientation?file=index.ts

@Markel
Copy link
Contributor

Markel commented Nov 23, 2020

Sorry for the late response @OliverJAsh

🤔💭 So this is kind of a partial support, how do you think we should approach this @rejas ?

(Background for whoever needs it: Modernizr only has two states: supported or not supported, parcial support is not contemplated)

@rejas
Copy link
Member

rejas commented Nov 23, 2020

Ah, partial support... That already came up in #2476
But other than asking caniuse how they define partial support, not much has happened in that direction: Fyrd/caniuse#5119
Not sure how we can map that to our data...

@rejas rejas added the caniuse modernizr tests differ from caniuse results label Nov 23, 2020
@OliverJAsh OliverJAsh changed the title Exif orientation test incorrectly returns false in iOS Safari version 12 and below Exif orientation test incorrectly returns false in iOS Safari version 13.3 and below Nov 24, 2020
@richex-cn
Copy link

I'm also meet this problem in iPhone OS 12.0, and no solution has been found yet, So I used a temporary solution, just check userAgent is iPhone and version less than 13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caniuse modernizr tests differ from caniuse results
Projects
None yet
Development

No branches or pull requests

4 participants