Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pager_ajaxProcessing could be a useful default function #1580

Closed
toabi opened this issue Aug 24, 2018 · 3 comments
Closed

pager_ajaxProcessing could be a useful default function #1580

toabi opened this issue Aug 24, 2018 · 3 comments

Comments

@toabi
Copy link

toabi commented Aug 24, 2018

See widgets/widget-pager.js#L94 - if you don't configure it, it returns nothing, even if your ajax endpoint already returns the data in exactly the format you would need.

In that case you then have to everywhere configure pager_ajaxProcessing: function(data){return data}.

Could that not be the default?

@Mottie
Copy link
Owner

Mottie commented Aug 24, 2018

Hi @toabi!

That makes total sense. I'll update both pagers (addon & widget) and it will be available in the next release.

@toabi
Copy link
Author

toabi commented Aug 24, 2018

By the way, what's more future-proof? Using the addon or the widget? Thanks for that quick response too! 🎉

@toabi toabi closed this as completed Aug 24, 2018
@Mottie
Copy link
Owner

Mottie commented Aug 24, 2018

I'm maintaining both for now, but I plan on phasing out the addon in the future.

@Mottie Mottie removed the Next Update label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants