Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Uncommitted Changes to show git status #704

Open
jensenr30 opened this issue Feb 26, 2024 · 3 comments · May be fixed by #708
Open

Enhance Uncommitted Changes to show git status #704

jensenr30 opened this issue Feb 26, 2024 · 3 comments · May be fixed by #708
Assignees
Labels
enhancement New feature or request

Comments

@jensenr30
Copy link
Contributor

If the git repo is clean, the "Uncommitted Changes" line in the CommitList should say something like "Working tree clean" similar to how git says nothing to commit, working tree clean.

It would also be nice if the Item / text color changed. E.g. green for a clean repo, and bold red for a repo with uncommitted changes. Ideally the colors come from the existing palette / QPalette.

Also if the working tree is clean, then the user should not be able to select that line in the CommitList.

@jensenr30
Copy link
Contributor Author

Feel free to assign this issue to me.

Here are some examples of what I'm thinking. Open to critical feedback.

I tried making "working tree clean" green, but it looked weird. Probably best to keep it the same color as the other text.

gittyup-working-tree-clean

I think a dark/faded red background could look good. We could use the same red color as the one from the diff view to keep the theme coherent.

gittyup-uncommitted-changes

@Murmele
Copy link
Owner

Murmele commented Feb 27, 2024

Thanks for the proposal. I think the last image is a little bit too much. Because when looking through the history it forces you always looking on this red banner. I would make something less attracting.

@Murmele Murmele added the enhancement New feature or request label Feb 27, 2024
@jensenr30 jensenr30 linked a pull request Mar 5, 2024 that will close this issue
@Murmele
Copy link
Owner

Murmele commented Mar 7, 2024

This is only when the option "Show Clean Status" is enabled right?

Current:
grafik

Another issue here is that some changes are shown in the treeview, but selecting one does not show the file (Because there are no changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants