Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile on Windows - MSVC not compatible anymore #724

Open
TommyHolmberg opened this issue Mar 22, 2024 · 0 comments
Open

Compile on Windows - MSVC not compatible anymore #724

TommyHolmberg opened this issue Mar 22, 2024 · 0 comments

Comments

@TommyHolmberg
Copy link

TommyHolmberg commented Mar 22, 2024

In the readme it says that MSVC is the way to build on Windows. However, because git-credential-wincred.c now have attribute and some of the CMake files require -Werror flag, MSVC is no longer compatible.

If you look in the GitAhead repo it doesnt have those flags and it relies on a pretty old git submodule from over 6 years ago where the attribute was not added. That's why it's compatible with MSVC.

I was able to compile with MinGW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant