-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved: New Skill: CatchAll Fallback asks to repeat phrase when no intent determined #2612
Comments
I recommend this be a skill in the marketplace or possible a default skill in the core 'cannon'. @forslund, thanks for the example!.. feel free to add this CatchAll skill if you'd like. |
Might be something that could be added to the fallback-unknown skill Maybe move the issue there or to the mycroft-skills repo (since this is more skill related than core related). Glad that my old example skill came in handy :) |
@forslund Ah right, the skills repo, yes.. will move. (I had started it in the fallback-unknown skill, but didnt want it to tell me to 'Please wait a moment as I finish booting up'.. which, actually, I dont see in the dialogs for that skill, so I wonder if its coming from elsewhere.) Hey, I'm actually debugging it right now.. I didnt realize the it is overriding other skills until I started working on another one. Any suggestion on how to catch just everything that isnt a skill intent? I thought that was what the fallbacks did, but your example uses several word verification steps. |
moving this to MycroftAI/mycroft-skills#1340 |
To answer your question, the fallbacks have priority (1-100) so a fallback with the prio 1 will be checked before a fallback with prio 2. The example has the prio 1. self.register_fallback(self.handle_fallback, 1) which is good to show it's executing BUT is bad since 1 is before a lot of important things: before the Padatious intent parser which is prio 10 I think. The fallback-unknown is set to prio 100 self.register_fallback(self.handle_fallback, 100) So you might want to set your skill to 99 to be just before the fallback-unknown but let all other skills try to match the sentence. See the api documentation for some guide to the ranges: https://mycroft-core.readthedocs.io/en/latest/source/mycroft.html#fallbackskill-class |
Following the docs on Fallbacks here: https://mycroft-ai.gitbook.io/docs/skill-development/skill-types/fallback-skill, and the example here: https://github.com/forslund/fallback-meaning, and figuring out the correct syntax by trial and error here: #2611, and adding the following lines of code (the second part replacing the Arthur Dent intent finding), the fallback now asks a follow up question 'What was that?' whenever an intent cannot be determined. (several variation on that vocab could be added to the
self.speak_dialog('CatchAllFallback')
The text was updated successfully, but these errors were encountered: