Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation in other debian-related os #3149

Open
luca-vercelli opened this issue Jan 15, 2023 · 4 comments
Open

installation in other debian-related os #3149

luca-vercelli opened this issue Jan 15, 2023 · 4 comments

Comments

@luca-vercelli
Copy link
Contributor

The ./dev_setup.sh fails under Peppermint, with the error: Could not find package manager. I think this also happens with many other non-common Debian-based os'.

This happens because the function install_deps() looks for specific os names:

if os_is_like debian || os_is debian || os_is_like ubuntu || os_is ubuntu || os_is linuxmint

why not just search for apt-get tool?

if found_exe apt-get
@forslund
Copy link
Collaborator

As I recall there were issues with non-debian os's that included apt (or had the possibility to add apt) without it being the primary package manager causing issues. So we couldn't just look at if apt existed on the system.

But maybe that could be added as a fallback? If no supported os was detected check for the specific package managers and try it?

@MarkMLl
Copy link

MarkMLl commented Jan 31, 2023

Are we talking about apt or the older (but I believe more comprehensive) apt-get here?

@luca-vercelli
Copy link
Contributor Author

The installer uses apt-get, not apt:

$SUDO apt-get install "${APT_PACKAGE_LIST[@]}"

@luca-vercelli
Copy link
Contributor Author

I suggest to add a fallback after all the other if conditions failed, something like

[...]
elif found_exe apt-get
    echo "$GREEN Installing packages for other Debian-related distro...$RESET" | tee -a /var/log/mycroft/setup.log
    debian_install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants