Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnvironmentControls updates #531

Closed
wants to merge 16 commits into from
Closed

EnvironmentControls updates #531

wants to merge 16 commits into from

Conversation

gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented Apr 26, 2024 •
edited

Related to #438
Fix #530

  • Fix zoomed out rotation action scale
  • Fix GlobeControls: Zooming out past threshold increases zoom speed

TODO

  • Separate PR for simplification & polish, first
    • Simplify logic
    • Simplify use of zoom point where possible
    • Ensure actions scale based on pixel density
  • Add function for retrieving the last interacted point
  • The logic of the controls relies on positioning - see if we can fix that? Perhaps set the camera distance at a certain position based on zoom?

@gkjohnson
Copy link
Contributor Author

Closing in favor of #537

@gkjohnson gkjohnson closed this May 9, 2024
@gkjohnson gkjohnson deleted the env-controls-update branch May 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EnvironmentControls: Get last known / used distance or point
1 participant
@gkjohnson