Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that packageId is an id #354

Open
mbjones opened this issue Jan 23, 2020 · 0 comments
Open

clarify that packageId is an id #354

mbjones opened this issue Jan 23, 2020 · 0 comments
Assignees

Comments

@mbjones
Copy link
Member

mbjones commented Jan 23, 2020

The validation rules were clarified in issue #306 but we failed to indicate that packageId should be included in the list of id instances that should be both unique and checked when resolving references. This seems to be affecting the validation in the R emld package. @cboettig let's discuss the issues I am seeing.

In addition, we should be clear in the validation rules that we are ignoring the system attribute, so probably need to remove or edit this rule:

  • When references is used, the system attribute MUST have the same value in both the target and source elements, or it must be absent in both. Frequently it is absent in both.
@mbjones mbjones self-assigned this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant