Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "Company offers" route to another place #323

Open
Naapperas opened this issue Jun 21, 2023 · 0 comments · May be fixed by #342
Open

Move "Company offers" route to another place #323

Naapperas opened this issue Jun 21, 2023 · 0 comments · May be fixed by #342
Assignees
@jacribeiro
Labels
development newcomer friendly P0 High priority

Comments

@Naapperas
Copy link
Member

Currently, in order to fetch a company's offers, one has to call /offers/company/:companyId, present in the "Offers router".

It makes much more sense to have this route has /company/:id/offers on the "Company router".

Since this can be a breaking change it should only be included in a new major release.

All the corresponding tests have to be updated, perhaps that should come after #311 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacribeiro jacribeiro

Labels
development newcomer friendly P0 High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed company offers route to /company/:companyid/offers NIAEFEUP/nijobs-be
2 participants
@Naapperas @jacribeiro