Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that CO2 and GenContam are handled by all components #10473

Open
3 tasks
mjwitte opened this issue Apr 19, 2024 · 0 comments
Open
3 tasks

Make sure that CO2 and GenContam are handled by all components #10473

mjwitte opened this issue Apr 19, 2024 · 0 comments

Comments

@mjwitte
Copy link
Contributor

mjwitte commented Apr 19, 2024

Issue overview

  1. While reviewing another PR, noticed that GenContam isn't getting passed through by variable speed coils, only CO2 is.

    if (state.dataContaminantBalance->Contaminant.CO2Simulation) {
    state.dataLoopNodes->Node(AirOutletNode).CO2 = state.dataLoopNodes->Node(AirInletNode).CO2;
    }

  2. While working on Error with Zone Air Contaminant Balance #10348 noticed this for SpaceHVAC:ZoneEqupimentMixer.

    for (auto &mixerSpace : this->spaces) {
    auto &spaceOutletNode = state.dataLoopNodes->Node(mixerSpace.spaceNodeNum);
    sumEnthalpy += spaceOutletNode.Enthalpy * mixerSpace.fraction;
    sumHumRat += spaceOutletNode.HumRat * mixerSpace.fraction;
    sumCO2 += spaceOutletNode.CO2 * mixerSpace.fraction;
    sumPressure += spaceOutletNode.Press * mixerSpace.fraction;
    sumFractions += mixerSpace.fraction;
    }
    equipInletNode.Enthalpy = sumEnthalpy / sumFractions;
    equipInletNode.HumRat = sumHumRat / sumFractions;
    equipInletNode.CO2 = sumCO2 / sumFractions;
    equipInletNode.Press = sumPressure / sumFractions;

  3. Need to check the entire code base to make sure that CO2 and GenContam are being calculated and/or passed through as needed.

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@mjwitte mjwitte changed the title Make sure that CO2 and GenContam are handled by all components. Make sure that CO2 and GenContam are handled by all components Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant