Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIA-Umpire crashes due to a FragPipe bug #1454

Closed
nicolasgrinberg opened this issue Feb 21, 2024 · 9 comments
Closed

DIA-Umpire crashes due to a FragPipe bug #1454

nicolasgrinberg opened this issue Feb 21, 2024 · 9 comments
Assignees
Labels

Comments

@nicolasgrinberg
Copy link

Hi,

I am trying to run hybridDIA with 54 DIA folders and 57 DDA folders. I set a 3% FDR with group-specific FDR. I want to set the DDA folders as DDA+ but it keeps crashing unfortunately. Is it possible to use DDA+ with hybrid DIA? Thanks in advance,

Nico
log_2024-02-21_11-19-47.txt

@fcyu
Copy link
Member

fcyu commented Feb 21, 2024

The error was from DIA-Umpire. @guoci can you take a look?

Thanks,

Fengchao

@fcyu fcyu changed the title Fragpipe crashes when running hybridDIA with DDA+ DIA-Umpire crashes Feb 21, 2024
@nicolasgrinberg
Copy link
Author

Hello, are there any news on this? Is it possible to use both DDA+ and hybrid DIA?

@fcyu
Copy link
Member

fcyu commented Feb 26, 2024

Hi @nicolasgrinberg ,

The error is not about DIA+. It was thrown by DIA-Umpire (as the new title I have changed), which is before MSFragger starts. We are waiting for Guo Ci to take a look at the error because he knows DIA-Umpire the best. He might be busy at something else, so it might take a while.

Best,

Fengchao

@anesvi
Copy link
Collaborator

anesvi commented Feb 26, 2024

I looked at the log file and noticed a few things. DIA-Umpire crashed, as Fengchao pointed out. However, looking in more detail:

  1. From a the file name, you are doing HLA peptidomics
  2. Your DIA data is narrow window
    Processing DIA MS2 (mz range):1610.7758_1611.9757( 15/37495 )
    Is is Astral data? If so, we have a different workflow we can recommend that works well for Astral DIA data.
    I suggest you contact me directly via email.
    Best,
    Alexey

@guoci guoci removed their assignment Mar 6, 2024
@anesvi
Copy link
Collaborator

anesvi commented Mar 7, 2024

So we determined there was a bug in FragPipe when DIA and DIA data were searched together and DDA specified as DDA+. Will be fixed in the next release.

@fcyu fcyu added FragPipe and removed DIA-Umpire labels Mar 7, 2024
@fcyu fcyu self-assigned this Mar 7, 2024
@fcyu fcyu changed the title DIA-Umpire crashes DIA-Umpire crashes due to a FragPipe bug Mar 7, 2024
@ds2268
Copy link

ds2268 commented Mar 29, 2024

I looked at the log file and noticed a few things. DIA-Umpire crashed, as Fengchao pointed out. However, looking in more detail:

1. From a the file name, you are doing HLA peptidomics

2. Your DIA data is narrow window
   Processing DIA MS2 (mz range):1610.7758_1611.9757( 15/37495 )
   Is is Astral data? If so, we have a different workflow we can recommend that works well for Astral DIA data.
   I suggest you contact me directly via email.
   Best,
   Alexey

@anesvi can you elaborate more on the proposed Astral workflow that we can use with MSFragger-DIA? It would be great to have such information public (README?) for the wider audience to benefit. Thanks!

@fcyu
Copy link
Member

fcyu commented Mar 29, 2024

Hi @ds2268 ,

You can use the existing built-in DIA related workflows, just not set the DDA data to DDA+ data type for now.

Best,

Fengchao

@ds2268
Copy link

ds2268 commented Mar 29, 2024

Hi @fcyu.

Just to confirm: for the nDIA data, as collected for example here you suggest running the MSFragger-DIA workflow, as presented here?

The following was mentioned above: "Is is Astral data? If so, we have a different workflow we can recommend that works well for Astral DIA data."

@fcyu
Copy link
Member

fcyu commented Mar 29, 2024

Correct. The DIA_SpecLib_Quant workflow performs better than the DIA_DIA-Umpire_SpecLib_Quant for Astral data.

Best,

Fengchao

@fcyu fcyu closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants