Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n_fr_siret: company_registry field on res.partner is native since v16 #501

Open
alexis-via opened this issue Dec 29, 2023 · 3 comments
Open
Labels

Comments

@alexis-via
Copy link
Contributor

The stupid guy who migrated l10n_fr_siret to v16 (me !) didn't spot that the field company_registry was added by Odoo SA in the base module, cf https://github.com/odoo/odoo/blob/16.0/odoo/addons/base/models/res_partner.py#L225
This field is used to store the national company identification number, cf for example the code of l10n_be and l10n_ro (they auto-extract it from the VAT number).

From my understanding, the field company_registry of l10n_fr was designed to write the name of the RCS where the company was registered. For example, for Akretion France which is RCS Lyon 792377731, then company_registry would store "Lyon". I don't use that field myself, and I don't find it useful. l10n_fr_siret was ported to v16 one year ago, and nobody found the bug yet... so I guess that I'm not the only one who don't use that field !!!

2 options:

  1. remove company registry in l10n_fr_siret because we think that it's not useful
  2. rename the field: for example fr_company_registry

I vote for option 1.

@alexis-via alexis-via added the bug label Dec 29, 2023
@legalsylvain
Copy link
Contributor

Thanks for your investigation !
Option 1.

@matthieusaison
Copy link

🗳️ Option 1

@hparfr
Copy link

hparfr commented Jan 2, 2024

Option 1

alexis-via added a commit to akretion/l10n-france that referenced this issue May 26, 2024
Fix bug OCA#501: don't redefine field company_registry on res.partner ;
that field is defined in the "base" module since odoo v16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants