Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRCREV is ignored in linux-tegra_4.9.bb #1415

Open
MichaelPres opened this issue Nov 14, 2023 · 3 comments
Open

SRCREV is ignored in linux-tegra_4.9.bb #1415

MichaelPres opened this issue Nov 14, 2023 · 3 comments

Comments

@MichaelPres
Copy link

Hi,

In branch kirkstone-l4t-r32.7.x, the SRCREV is ignored:

rhc@ubuntu:/mnt/repos/kirkstone-offline/build$ buildhistory-collect-srcrevs | grep linux-tegra
SRCREV_machine:pn-linux-tegra = "a1cf17bc0aa0dbafcd8c43514f57d90dc69442a0"

Here is what I propose:

diff --git a/recipes-kernel/linux/linux-tegra_4.9.bb b/recipes-kernel/linux/linux-tegra_4.9.bb
index 6528f29..5c2471c 100644
--- a/recipes-kernel/linux/linux-tegra_4.9.bb
+++ b/recipes-kernel/linux/linux-tegra_4.9.bb
@@ -22,7 +22,7 @@ LINUX_VERSION_EXTENSION ?= "-l4t-r${L4T_VERSION}"
 SCMVERSION ??= "y"
 
 SRCBRANCH = "oe4t-patches${LINUX_VERSION_EXTENSION}"
-SRCREV = "a1cf17bc0aa0dbafcd8c43514f57d90dc69442a0"
+SRCREV_machine = "a1cf17bc0aa0dbafcd8c43514f57d90dc69442a0"
 KBRANCH = "${SRCBRANCH}"
 SRC_REPO = "github.com/OE4T/linux-tegra-4.9;protocol=https"
 KERNEL_REPO = "${SRC_REPO}"
@madisongh
Copy link
Member

SRCREV is not ignored; the value its set to gets propagated to the SRCREV_machine variable (since our source repo has name=machine). Since we don't actually use a meta repository, we could probably update the recipe to set SRCREV_FORMAT to the null string and remove the name=machine parameter from the SRC_URI setting. That would clean up the buildhistory output... I'm just not sure if there any assumptions in the kernel-yocto bbclass about there being a source repo tagged with name=machine that would break builds if we did that.

@ichergui
Copy link
Member

Hi @MichaelPres
Any updates on this issue ?
Otherwise I will close it.

@MichaelPres
Copy link
Author

@ichergui I am using the patch locally since @madisongh say it is not required in previous message. I don't have the time look for SRCREV_FORMAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants