Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAPI integration #189

Merged
merged 13 commits into from Feb 16, 2023
Merged

WebAPI integration #189

merged 13 commits into from Feb 16, 2023

Conversation

Mikhail-iontsev
Copy link
Collaborator

@Mikhail-iontsev Mikhail-iontsev commented Oct 21, 2022

Closes #183

WebAPI settings are located in the env folder. Cross-origin is supported if your WebAPI instance is configured to allow such requests.

To point the app to your WebAPI instance, please change the "WEB_API_URL" variable in the env.json file (no need to rebuild the app after that).

To authenticate please indicate your azure domain and client id in the env.json file.

@Mikhail-iontsev Mikhail-iontsev marked this pull request as ready for review October 24, 2022 12:19
@fdefalco
Copy link
Contributor

fdefalco commented Nov 1, 2022

Getting the following error after updating the env.json file with the following settings:

{
"WEB_API_URL": "https://epi.jnj.com:8443/WebAPI",
"WEB_API_ENABLED": "true",
"AZURE_AUTH_DOMAIN": "",
"AZURE_CLIENT_ID": ""
}

image

Do I need settings for the 3rd and 4th property?

@Mikhail-iontsev
Copy link
Collaborator Author

Yes, for the auth to work you'll need to specify your client id (for that you need to register the app in Azure dashboard) and your auth domain (also found there).

I'm still trying to understand how the domain auth works, but it doesn't seem to work in all cases (depends on the browser and the OS version)

@fdefalco
Copy link
Contributor

fdefalco commented Nov 1, 2022

Ok, we aren't on an Azure hosted domain. I can demo the issue for you tomorrow on our status call.

@fdefalco
Copy link
Contributor

fdefalco commented Nov 9, 2022

@Mikhail-iontsev per our discussion:

  • modify font size in drop down from 16 to 12 to be consistent with UI
  • change spacing in concept results table to be 'dense'
  • make columns sortable
  • limit results to standard concept (STANDARD_CONCEPT == S)

Also found the following that shows that it is possible to post to the search service and request only standard concepts.

https://github.com/OHDSI/WebAPI/blob/fad7c7c553cf9f21f37b4619a9d96610c4185893/src/main/java/org/ohdsi/webapi/service/VocabularyService.java#L523

@Mikhail-iontsev
Copy link
Collaborator Author

"modify font size in drop down from 16 to 12 to be consistent with UI" - it would be better to create a separate task as changes should be made in all reports using the v-data-table component.

Mikhail-iontsev and others added 4 commits November 11, 2022 05:59
…n, only standard concepts are requested, sortable columns
# Conflicts:
#	src/widgets/explorer/model/store/explorer.module.js
@fdefalco
Copy link
Contributor

fdefalco commented Feb 3, 2023

@Mikhail-iontsev sorry that I let this get stale.. Can you update to merge to the new develop branch with the vue 3.0 transition?

…_vue3

# Conflicts:
#	.eslintrc
#	package.json
#	src/app/App.vue
#	src/app/providers/store/index.ts
#	src/main.ts
#	src/pages/reports/network/NetworkDataFeasibilityReport/components/DesiredDomains.vue
#	src/pages/reports/network/NetworkDataFeasibilityReport/components/DomainRequirements.vue
#	src/pages/reports/network/NetworkDataFeasibilityReport/components/FinalEstimation.vue
#	src/pages/reports/network/NetworkDataFeasibilityReport/components/Range.vue
#	src/pages/reports/network/NetworkDataFeasibilityReport/components/RequiredConcepts.vue
#	src/pages/reports/network/NetworkDataFeasibilityReport/components/VisitTypes.vue
#	src/pages/reports/network/NetworkDataFeasibilityReport/index.vue
#	src/processes/exploreReports/config/routes.ts
#	src/processes/exploreReports/ui/ReportsView.vue
#	src/shared/api/apiService.js
#	src/shared/lib/mixins/methods/debouncedSearch.js
#	src/widgets/bottomNav/ui/BottomNav.vue
#	src/widgets/explorer/model/store/explorer.module.ts
#	src/widgets/explorer/ui/Explorer.vue
#	src/widgets/settings/ui/Settings.vue
@Mikhail-iontsev Mikhail-iontsev changed the base branch from main to development February 16, 2023 15:08
@fdefalco fdefalco merged commit 88e13ab into development Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional webapi integration for concept search
2 participants