Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show armor slots #25

Open
Braintelligence opened this issue Dec 1, 2018 · 26 comments
Open

Show armor slots #25

Braintelligence opened this issue Dec 1, 2018 · 26 comments

Comments

@Braintelligence
Copy link

Hi Odie!
It would be darned awesome if you could incorporate this: https://www.loverslab.com/files/file/1219-skyui-show-armor-slots/ into SkyUI VR 馃樇

@Braintelligence
Copy link
Author

@Odie
Copy link
Owner

Odie commented Dec 1, 2018

Hi there,

You also mentioned this link on reddit:
https://www.nexusmods.com/skyrimspecialedition/mods/17601?tab=files

Is the source for the dll available somewhere?

@Braintelligence
Copy link
Author

Braintelligence commented Dec 1, 2018

Sadly not, I think. Or else I would have tried to make it work myself. The link described in my second comment works if you "click away" the error messages, but then the VR control overview in the bottom left is gone.

But wait, what dll do you mean? The one that only displays armor slots only contains a config.txt and swf files if I remember correctly.

(The feature I'm missing like hell is armor slots, anything else would just be a bonus to me :D)

@Odie
Copy link
Owner

Odie commented Dec 1, 2018

Well, the mod on modnexus seems to include a base_armor.dll but doesn鈥檛 seem to have any links to the source. The mod also says it requires papyrus util which doesn鈥檛 yet have a very compatible version.

I鈥檒l look into the loverslab links at some point.

Btw, why is it useful to see which slots a piece of gear occupies?

@Braintelligence
Copy link
Author

Braintelligence commented Dec 1, 2018

Well, how else can you determine before smithing/buying or giving to your follower if it's an item that can be equipped without unequipping something else?
Sometimes you just can't tell if the armor you're about to loot/create/buy will overlap a slot already in use.

EDIT: You then also get the opportunity to sort your armor by armor slots. This is awesome if you only want to look at chest pieces, to compare with your current one.

This is especially true if you use mods that add equippable bags to the game or armor sets.

I had particular problems with the cbbe bikini armor set, because for some reason one specific armor type of chest pieces also preoccupied the groin slot.

I could only tell by using the mod from the second link.

Knowing what armor slots are occupied by items is an addition that would vastly improve my quality of life in Skyrim.
I think all that needs to be done is merging the config.txt and decompiling the swf to incorporate the changes that project the slot numbers into the bipedSlots column described in the config.txt

Afaik no DLLs are involved here.

I think the dll stuff is incorporated for the first mod mentioned which does a lot more than providing an armor slot column, which I personally wouldn't need. It's just the most current mod with armor slots I could find for sse.

@Braintelligence
Copy link
Author

Hm, it looks like the updated mod from loverslab got removed... Is there some mail address I could send you the archive to? The difference between the mod from the link and the current available mod on loverslab is the update from SkyUI 5.0 to SkyUI 5.1.

You can find the former here: https://www.loverslab.com/files/file/1219-skyui-show-armor-slots/

It only contains a config.txt and

  • bartermenu.swf
  • containermenu.swf
  • craftingmenu.swf
  • giftmenu.swf
  • inventorymenu.swf

No DLLs involved.

If I merge the config.txt with yours I get a column filled with dashes. I guess the compiled flash stuff can access the bipedSlots then?

@Odie
Copy link
Owner

Odie commented Dec 3, 2018

It's totally fine to just upload the mod here by drag 'n dropping into the text box you write comments in. This way the file will always be a part of the issue history. It'll be easy to keep track of.

The new column can't be added just by changing config.txt. Some changes will be required in the code for sure.

@Braintelligence
Copy link
Author

I'll attach the 5.0 version here and add the 5.1 version later. (I fear that the 5.1 version has some copyright violations or whatever, though.)

I'm 100% sure that I was able to add the column to SkyUI just by changing the config.txt - it just didn't display any value other than a dash -. The actual numbers seem to be accessed by the compiled flash.

SkyUI - show armor slots v5.zip

@Odie
Copy link
Owner

Odie commented Dec 3, 2018

It looks like the slot numbers are in the range of 30 ~ 62.
Is there a particular reason why it should start at 30? Why not from 0 ~ 32?

@Braintelligence
Copy link
Author

Well it seems that this is the way Bethesda handles those slots.
http://wiki.tesnexus.com/index.php/Skyrim_bodyparts_number

It could be interesting to allow a different visualization of this, but then how would you sort it? Maybe you could keep the numbers internally but visualize them as body parts?

@Odie
Copy link
Owner

Odie commented Dec 3, 2018

Okay, no worries then. I'll just keep it that way.

@Odie
Copy link
Owner

Odie commented Dec 3, 2018

Hi!

Try this out. It seems to work fine for me. Do let me know if there are any issues.

SkyUI - VR - armor slot display.zip

@Braintelligence
Copy link
Author

Awesome! I will try it out in approximately 8-12 hours when I'm back home 馃檲
Do you have some sort of donation gateway so I can tip you something for your work?

@Odie
Copy link
Owner

Odie commented Dec 3, 2018

haha~ no worries, man~
Just enjoy the game. =)

@Braintelligence
Copy link
Author

鈽癸笍 Let me drop some Steam goodness your way at least or something 馃檲.
Without you I'd have to deal with that crappy stock UI 馃槶.

@Odie
Copy link
Owner

Odie commented Dec 3, 2018

Well, if you really want to, you can find me as "SuperOdie" on Steam. =)

@Braintelligence
Copy link
Author

Now I just need you to accept my friend request :D

@Odie
Copy link
Owner

Odie commented Dec 4, 2018

Added! =)

@Braintelligence
Copy link
Author

Duh, I have to wait 3 days until I can gift you something. 馃樄

@Braintelligence
Copy link
Author

So the inventory menu works and shows slots accordingly. It doesn't work for crafting menus yet =(... Column is there but it only shows a dash where the value should be.

@Odie
Copy link
Owner

Odie commented Dec 5, 2018

Yikes... It looks like there is a largely identical piece of code that governs adding data to craft menu entries. Not awesome. =(

Anyway, here's the updated version.

SkyUI - VR - armor slot display - rev 2.zip

@Braintelligence
Copy link
Author

Sounds like refactoring is needed :p Will test when home.
If I remember correctly gifting menus and one or two more had also their own swf file.

@Odie
Copy link
Owner

Odie commented Dec 7, 2018

Well, I try to rebuild all the swf every time, precisely because it's not entirely clear which files are included/compiled into which swf(s).

The problem here is just having to track down every location where a piece of data might need to be annotated with the bipedSlotDisplay field.

@Braintelligence
Copy link
Author

I'll keep bugging you if I find a menu that doesn't work 馃棥 馃樇
Enjoy your steam gift ^^

@Odie
Copy link
Owner

Odie commented Dec 7, 2018

Thanks! Much appreciated! =)

@Mustrumion
Copy link

Just dropping to say that this variant of SkyUI still works and single-handedly saved my play through.
I was getting frustrated with the inability of grouping of modded items by slot taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants