Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight starred stops on map #680

Open
barbeau opened this issue Aug 24, 2016 · 1 comment · May be fixed by #1176
Open

Highlight starred stops on map #680

barbeau opened this issue Aug 24, 2016 · 1 comment · May be fixed by #1176
Milestone

Comments

@barbeau
Copy link
Member

barbeau commented Aug 24, 2016

Summary:

From user:

It would be neat to highlight starred stops on the map. When I'm scrolling around a crowded section of the map, that would help me orient / locate more quickly.

OBA iOS now has a feature that shows stop icons a different color if they are starred - see OneBusAway/onebusaway-iphone#569 for details - screenshot is below showing yellow-highlighted stops for favorites.

image

We may need to be careful with performance here, as currently all stops in the StopOverlay are held in memory as elements returned directly from the OBA REST API. To check if a particular stop is a starred stop, we need to pull that info from the local database. If we do this synchronously while the stops are being added to the map, it could cause slow-down, and the map can already be pretty sluggish at high zoom levels due to Google Maps v2 behavior. We should benchmark to make sure we're not adding to the problem. An option is to do the marking of favorites asynchronously after the makers are added to the map, and just update the image via Marker.setIcon().

Steps to reproduce:

  1. Go to "Nearby" view to show stops on the map, and hover over a stop you have starred

Expected behavior:

Have a different icon than an unstarred stop

Observed behavior:

Starred and unstarred stops look the same on the map

Device and Android version:

N/A

Screenshots:

See above for implementation on iOS.

@barbeau barbeau added this to the v2.2 milestone Aug 24, 2016
@barbeau barbeau modified the milestones: v2.4, v2.6 Apr 12, 2019
@barbeau
Copy link
Member Author

barbeau commented Jul 21, 2020

Newest iOS UI for this feature is at OneBusAway/onebusaway-ios#254 (comment)

image

@sebesti0n sebesti0n linked a pull request Mar 15, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant