Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to check some language related matters #549

Open
koenedaele opened this issue Jun 4, 2020 · 0 comments
Open

We need to check some language related matters #549

koenedaele opened this issue Jun 4, 2020 · 0 comments
Assignees
Labels

Comments

@koenedaele
Copy link
Member

koenedaele commented Jun 4, 2020

Atramhasis views get the current user's language from the request.locale_name parameter. This gets the locale_name from a LOCALE GET parameter or a cookie and falls back to the default locale.

Pyramid_skosprovider, which powers most of the JSON services, apart from the tree, also uses the request.locale_name, but allows it to be overridden with the language GET parameter.

Further complication: request.locale_name might look like en_US, while language should be IANA en-US. Unless the language tags lib handles the underscores.

Other complication: request.locale_name has a function to set a cookie that only allows setting it to the configured languages, which are the UI languages. Even though the provider might support other languages.

Other consideration, do we differentiatie between the request.locale_name that tells us what language the user's browser is configured for (applying to the interface) and a parameter like language that might tell us the user wants Latin for the concept labels, even though the UI should be in English? (Possibly related to #379 )

@koenedaele koenedaele self-assigned this Jun 4, 2020
@cedrikv cedrikv added this to the Sprint 132 milestone Jun 15, 2020
@claeyswo claeyswo modified the milestones: Sprint 132, Sprint 133 Jun 22, 2020
@claeyswo claeyswo modified the milestones: Sprint 133, Sprint 134 Jul 6, 2020
@claeyswo claeyswo modified the milestones: Sprint 134, Sprint 135 Jul 22, 2020
@claeyswo claeyswo modified the milestones: Sprint 135, Sprint 136 Aug 3, 2020
@koenedaele koenedaele removed this from the Sprint 136 milestone Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants