Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend and CSS could use a review #866

Open
Wim-De-Clercq opened this issue Mar 11, 2024 · 0 comments
Open

Frontend and CSS could use a review #866

Wim-De-Clercq opened this issue Mar 11, 2024 · 0 comments

Comments

@Wim-De-Clercq
Copy link
Contributor

Wim-De-Clercq commented Mar 11, 2024

  • CSS is currently still being build with compass which is end of life, no longer supported.
  • All of node modules needs to be present in the wheels. This really bloats the wheel but the atramhasis jinja templates look for targets in node_modules, so i can't remove them.
  • Also the documentation for customization https://atramhasis.readthedocs.io/en/latest/customisation.html#changing-the-css implies that you have all of the scss files of atramhasis into your own project to edit and build yourself to change to your own styling needs.
    You would have to download the files from github, add them to your project, edit, compile, and then override the css assets. This feels not very user (developer) friendly. Mostly the first step, to get the original scss files either from github or in a cookiecutter doesn't stick well with me.

I think we need to start seeing atramhasis more as a third-party library which you can install, use, and customize. Rather than a github project which you copy/clone the majority of and edit to your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant