Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS 4.1 Postgres 15 update docs are not working #6740

Open
depate opened this issue Feb 25, 2024 · 3 comments · May be fixed by #6741
Open

OS 4.1 Postgres 15 update docs are not working #6740

depate opened this issue Feb 25, 2024 · 3 comments · May be fixed by #6741
Assignees
Labels

Comments

@depate
Copy link

depate commented Feb 25, 2024

Describe the bug

The update routine is not working as described in the docs or a crucial part is missing.

How to Reproduce

Follow the "How to update routine" for 4.1.

Dump the database ✅
Update as documented ✅ (fix the new tag, pull, start up the containers),
Start containers 🔴
The mentioned database error appears.
The database container shuts down, so a restore is not possible.
Deadlock.

Expected behavior

Somewhere I database migration/upgrade is taking place.

Additional context

The docs don't say how the database is upgraded. The docs also say the “old” openslides tool shall fix a missed database dump, but don't really tell how and for me, it doesn't make any sense, because the tool is not involved in dumping or restoring at all.

Screenshots
If applicable, add screenshots to help explain your problem.

Please fix the docs.

Did anybody test these steps in the docs manually or via CI? 🤔

The merge responsible is: #6711

Merged by @rrenkert, introduced by @peb-adr

@depate depate added the bug label Feb 25, 2024
@colinmahns
Copy link

colinmahns commented Feb 26, 2024 via email

@depate
Copy link
Author

depate commented Feb 26, 2024

I settled on 4.0.17 as this is the latest version before 4.1.

During that, the proxy service got changed (got outsourced into its own repo), and I needed to make additional custom changes to the host port forwarding, so that automatic certificate resolution via Caddy works again.

Maybe this is worth another issue report.

Semantic versioning doesn't work this way.

I'm really glad Open Slides is Open Source, but it isn't fun to administrate.

@peb-adr peb-adr linked a pull request Feb 26, 2024 that will close this issue
@peb-adr
Copy link
Member

peb-adr commented Feb 26, 2024

I'm sorry to hear the update didn't work for you.

It seems like I forgot to include the step of removing the postgres-data volume in the instructions.

So basically just running docker-compose down -v before starting containers with the new images was missing.
However now I expanded the instructions to hopefully also be more safe and clear about potential data loss.

I think for some reason I was under the impression that, because the dump is done with --clean it would take care of once removing all data and then reinserting it. It seems I did not think/test that through til the end.

Sorry for the inconvenience.
I updated the doc in #6741
Could you please test it and verify that it is now possible to perform the update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants