This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
2f0b25d
commit 070dcf0
Showing
12 changed files
with
735 additions
and
92 deletions.
There are no files selected for viewing
87 changes: 76 additions & 11 deletions
87
internal/allowed/assignment_candidate/assignment_candidate.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,83 @@ | ||
package assignment_candidate | ||
|
||
import "github.com/OpenSlides/openslides-permission-service/internal/allowed" | ||
import ( | ||
"github.com/OpenSlides/openslides-permission-service/internal/allowed" | ||
"github.com/OpenSlides/openslides-permission-service/internal/definitions" | ||
) | ||
|
||
// TODO: through model... | ||
// TODO: assignments.can_nominate_self and assignments.can_nominate_other | ||
var Create = allowed.BuildCreate([]string{ | ||
var selfCreate = allowed.BuildCreateThroughId([]string{ | ||
"assignment_id", | ||
"user_id", | ||
}, "assignments.can_manage") | ||
}, "assignment", "assignment_id", "assignments.can_nominate_self") | ||
var otherCreate = allowed.BuildCreateThroughId([]string{ | ||
"assignment_id", | ||
"user_id", | ||
}, "assignment", "assignment_id", "assignments.can_nominate_other") | ||
|
||
func Create(params *allowed.IsAllowedParams) (map[string]interface{}, error) { | ||
userID, err := allowed.GetId(params.Data, "user_id") | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
if userID == params.UserID { | ||
return selfCreate(params) | ||
} else { | ||
return otherCreate(params) | ||
} | ||
} | ||
|
||
var Sort = allowed.BuildModifyThroughId([]string{ | ||
"assignment_id", | ||
"candidate_ids", | ||
}, "assignment_candidate", "assignment", "assignment_id", "assignments.can_manage") | ||
|
||
func Delete(params *allowed.IsAllowedParams) (map[string]interface{}, error) { | ||
if err := allowed.ValidateFields(params.Data, allowed.MakeSet([]string{"id"})); err != nil { | ||
return nil, err | ||
} | ||
|
||
isAllowed, err := allowed.CheckUser(params) | ||
if err != nil { | ||
return nil, err | ||
} | ||
if isAllowed { | ||
return nil, nil | ||
} | ||
|
||
id, err := allowed.GetId(params.Data, "id") | ||
if err != nil { | ||
return nil, err | ||
} | ||
fqid := definitions.FqidFromCollectionAndId("assignment_candidate", id) | ||
exists, err := allowed.DoesModelExists(fqid, params.DataProvider) | ||
if err != nil { | ||
return nil, err | ||
} | ||
if !exists { | ||
return nil, allowed.NotAllowedf("The assignment_candidate with id %d does not exist", id) | ||
} | ||
userFqfield := definitions.FqfieldFromFqidAndField(fqid, "user_id") | ||
assignmentCandidateUserID, err := params.DataProvider.GetInt(userFqfield) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
meetingID, err := allowed.GetMeetingIDFromModel(fqid, params.DataProvider) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
// TODO: through model... | ||
// needs assignments.can_manage from the meeting of the assignment | ||
var Sort = allowed.BuildModify([]string{"assignment_id", | ||
"candidate_ids"}, "assignment", "assignments.can_manage") | ||
var permission string | ||
if assignmentCandidateUserID == params.UserID { | ||
permission = "assignments.can_nominate_self" | ||
} else { | ||
permission = "assignments.can_nominate_other" | ||
} | ||
|
||
// TODO: assignments.can_nominate_self and assignments.can_nominate_other | ||
var Delete = allowed.BuildModify([]string{"id"}, "assignment", "assignments.can_manage") | ||
err = allowed.CheckCommitteeMeetingPermissions(params, meetingID, permission) | ||
if err != nil { | ||
return nil, err | ||
} | ||
return nil, nil | ||
} |
134 changes: 134 additions & 0 deletions
134
internal/allowed/assignment_candidate/assignment_candidate_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
package assignment_candidate_test | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
"github.com/OpenSlides/openslides-permission-service/internal/allowed" | ||
"github.com/OpenSlides/openslides-permission-service/internal/allowed/assignment_candidate" | ||
"github.com/OpenSlides/openslides-permission-service/internal/definitions" | ||
"github.com/OpenSlides/openslides-permission-service/internal/tests" | ||
) | ||
|
||
func TestCreate(t *testing.T) { | ||
t.Run("ValidPermissionSelf", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment", 1) | ||
data := definitions.FqfieldData{ | ||
"assignment_id": []byte("1"), | ||
"user_id": []byte("1"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_self") | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsAllowed(t, assignment_candidate.Create, params) | ||
}) | ||
t.Run("ValidPermissionOther", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment", 1) | ||
data := definitions.FqfieldData{ | ||
"assignment_id": []byte("1"), | ||
"user_id": []byte("2"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_other") | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsAllowed(t, assignment_candidate.Create, params) | ||
}) | ||
t.Run("InvalidPermissionSelf", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment", 1) | ||
data := definitions.FqfieldData{ | ||
"assignment_id": []byte("1"), | ||
"user_id": []byte("1"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_other") // the wrong permission | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsNotAllowed(t, assignment_candidate.Create, params) | ||
}) | ||
t.Run("InvalidPermissionOther", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment", 1) | ||
data := definitions.FqfieldData{ | ||
"assignment_id": []byte("1"), | ||
"user_id": []byte("2"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_self") // the wrong permission | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsNotAllowed(t, assignment_candidate.Create, params) | ||
}) | ||
t.Run("NoUserId", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment", 1) | ||
data := definitions.FqfieldData{ | ||
"assignment_id": []byte("1"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_self") | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_other") | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsNotAllowed(t, assignment_candidate.Create, params) | ||
}) | ||
} | ||
|
||
func TestDelete(t *testing.T) { | ||
t.Run("ValidPermissionSelf", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment_candidate", 1) | ||
dp.Set("assignment_candidate/1/user_id", "1") | ||
data := definitions.FqfieldData{ | ||
"id": []byte("1"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_self") | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsAllowed(t, assignment_candidate.Delete, params) | ||
}) | ||
t.Run("ValidPermissionOther", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment_candidate", 1) | ||
dp.Set("assignment_candidate/1/user_id", "2") | ||
data := definitions.FqfieldData{ | ||
"id": []byte("1"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_other") | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsAllowed(t, assignment_candidate.Delete, params) | ||
}) | ||
t.Run("InvalidPermissionSelf", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment_candidate", 1) | ||
dp.Set("assignment_candidate/1/user_id", "1") | ||
data := definitions.FqfieldData{ | ||
"id": []byte("1"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_other") // wrong permission | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsNotAllowed(t, assignment_candidate.Delete, params) | ||
}) | ||
t.Run("InvalidPermissionOther", func(t *testing.T) { | ||
dp := tests.NewTestDataProvider(context.Background()) | ||
dp.AddBasicModel("assignment_candidate", 1) | ||
dp.Set("assignment_candidate/1/user_id", "2") | ||
data := definitions.FqfieldData{ | ||
"id": []byte("1"), | ||
} | ||
dp.AddUserToMeeting(1, 1) | ||
dp.AddPermissionToGroup(1, "assignments.can_nominate_self") // wrong permission | ||
params := &allowed.IsAllowedParams{UserID: 1, Data: data, DataProvider: dp.GetDataprovider()} | ||
|
||
allowed.AssertIsNotAllowed(t, assignment_candidate.Delete, params) | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.