Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop relying implicit Bacon.js stream ordering and update library #3129

Open
maurizi opened this issue May 16, 2017 · 1 comment
Open

Stop relying implicit Bacon.js stream ordering and update library #3129

maurizi opened this issue May 16, 2017 · 1 comment

Comments

@maurizi
Copy link
Contributor

maurizi commented May 16, 2017

I attempted to update Bacon.js as part of #3128, but updating caused regressions in our search handling code (as well as possibly other places).

The regressions are due to a reliance on the implicit ordering of calls to onValue that changed from one version to another. One onValue was storing data in the DOM as a side-effect, and a filter in another stream was attempting to read that data. The proper way to fix this is to ensure that all data dependencies of streams are captured by the stream itself.

@RobinIsTheBird
Copy link
Contributor

That could explain part of why adding any new component to the search Bacon is hard. Glad to see this as an issue. Is there another issue for updating Bacon that is blocked on this one?

@dboyer dboyer added the high label Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants