You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I attempted to update Bacon.js as part of #3128, but updating caused regressions in our search handling code (as well as possibly other places).
The regressions are due to a reliance on the implicit ordering of calls to onValue that changed from one version to another. One onValue was storing data in the DOM as a side-effect, and a filter in another stream was attempting to read that data. The proper way to fix this is to ensure that all data dependencies of streams are captured by the stream itself.
The text was updated successfully, but these errors were encountered:
That could explain part of why adding any new component to the search Bacon is hard. Glad to see this as an issue. Is there another issue for updating Bacon that is blocked on this one?
I attempted to update Bacon.js as part of #3128, but updating caused regressions in our search handling code (as well as possibly other places).
The regressions are due to a reliance on the implicit ordering of calls to
onValue
that changed from one version to another. OneonValue
was storing data in the DOM as a side-effect, and afilter
in another stream was attempting to read that data. The proper way to fix this is to ensure that all data dependencies of streams are captured by the stream itself.The text was updated successfully, but these errors were encountered: