disable -Werror=format-security #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still an issue for you? The ADEPT package is going to be removed sometime in the next ~year, so I don't want to go to heroic effort to address this. On the other hand, I made a lot of changes to the way ADEPT works a while back and I don't think this hs been updated since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198
On many linux distros,
-Werror=format-securityis used causing compilation failure with OpenVSP (Particularly introduced with the following OpenVSP commit:406d923#diff-7cafe6ca1c1cd0a10789daddf145fda0b71ca0bcb176f6e063684b51469db725R76.Archlinux, Ubuntu
I tried spending some time on how to minimally rewrite the code to make it secure, but was unable to think how to do so without rewriting a good bit of the reading/writing part of the above referenced commit.
This PR proposes to disable to errors as to keep linux users happy until a proper solution is rolled.