Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated code in testsuite #304

Open
tkoskela opened this issue Jan 12, 2024 · 0 comments · Fixed by #334
Open

Repeated code in testsuite #304

tkoskela opened this issue Jan 12, 2024 · 0 comments · Fixed by #334
Labels
area: testing Relating to the test suite priority: minor type: maintenance Refactoring, updating etc

Comments

@tkoskela
Copy link
Contributor

The individual test cases (def test_001, def test_002, etc.) in test_check_output.py repeat almost the same three lines of code for every test case. This could be simplified to parametrize on both the test directory and the keys to be checked.
@tkoskela tkoskela added area: testing Relating to the test suite priority: minor type: maintenance Refactoring, updating etc labels Jan 12, 2024
@connoraird connoraird mentioned this issue Feb 22, 2024
Merged
@connoraird connoraird linked a pull request Feb 22, 2024 that will close this issue
Removing repeated code in python test file #334
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: testing Relating to the test suite priority: minor type: maintenance Refactoring, updating etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing repeated code in python test file OrderN/CONQUEST-release
1 participant
@tkoskela