Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #81

Open
na4ma4 opened this issue Jan 12, 2023 · 7 comments
Open

Docker support #81

na4ma4 opened this issue Jan 12, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@na4ma4
Copy link

na4ma4 commented Jan 12, 2023

I've got a PR ready to add docker support.

Is it OK to add github actions for building the image, I'll also need to add a command line option to allow changing the bind address for view so it can be bound to 0.0.0.0 for the container.

If's that's all good I'll go ahead and put in the PR.

@Owez Owez self-assigned this Jan 12, 2023
@Owez Owez added the enhancement New feature or request label Jan 12, 2023
@Owez
Copy link
Owner

Owez commented Jan 12, 2023

Yep, github actions are totally fine to use, I was going to use it for linting/formatting soon. Can you add a --port= option with that new --host= option for the viewer so it configuring it is a bit more feature complete? Once that's good i'll review and merge

@na4ma4
Copy link
Author

na4ma4 commented Jan 12, 2023

What about using argparser for the flags and arguments ?

@Owez
Copy link
Owner

Owez commented Jan 13, 2023

What about using argparser for the flags and arguments ?

The homegrown one has a bit of life left in it, if it ain't broke don't fix it (for now). Eventually it should be replaced with something nice like click or the other popular one

@na4ma4
Copy link
Author

na4ma4 commented Jan 19, 2023

I've had a quick go but there's some bugs in the archiver-debt branch that I'll wait to get settled.

But basically the changes I was looking to make:

  • add bind_host, bind_port and open_in_webbrowser properties to Config.
  • add settings_flask method to Config.
  • add argument parsing to view command.
  • add a Dockerfile.

@na4ma4
Copy link
Author

na4ma4 commented Jan 19, 2023

And so I don't lose it, the help text for view.

yark view [name] [args?]

  Launches offline archive viewer website, optionally opening a webbrowser
  to view a specific archive.

Arguments:
  --disable-webbrowser  Disabled the automatic opening of a web browser
  --host=[host/ip]      Bind to specific IP or hostname
  --port=[port number]  Bind to a different port number than the default 7667

 Example:
  $ yark view
  $ yark view demo
  $ yark view demo --disable-webbrowser --host=0.0.0.0 --port=8080

@Owez
Copy link
Owner

Owez commented Jan 19, 2023

Them changes look good, if you take the branch as it is now at 0ee9be0 it should be stable enough to add. Made a design descision yesterday to opt for Python 3.11-only (#93) so you might have to update the image to it

@na4ma4 na4ma4 mentioned this issue Jan 30, 2023
@Owez
Copy link
Owner

Owez commented Feb 15, 2023

I'll leave this open even though #106 has been merged because the restructure with the new GUI has made it so docker is needed for yark-api specifically and not the current all-in-one dockerfile on the master branch at the moment

@Owez Owez removed their assignment Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: In Progress
Development

No branches or pull requests

2 participants