feat: support PHPUnit v9.1 naming for some asserts #7997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysztof-ciszewski
changed the title
krzysztof-ciszewski
changed the title
|
I don't know how to mark it as draft so I closed it, will reopen when done |
|
@krzysztof-ciszewski I've converted it to a draft, so feel free to push changes and verify with the full CI 🙂. |
Wirone
reviewed
May 9, 2024
|
@Wirone can you remove the draft now? The pipeline is green 🍾 |
|
@krzysztof-ciszewski no problem 🙂. FYI, for future contributions:
There is also possibility to create PR as draft (dedicated button on PR form). |
Wirone
changed the title
keradus
reviewed
May 10, 2024
keradus
reviewed
May 10, 2024
Comment on lines
+727
to
+735
| if ('assertnotisreadable' === $assertCall['loweredName']) { | ||
| $replacement = 'assertIsNotReadable'; | ||
| } elseif ('assertnotiswritable' === $assertCall['loweredName']) { | ||
| $replacement = 'assertIsNotWritable'; | ||
| } elseif ('assertdirectorynotexists' === $assertCall['loweredName']) { | ||
| $replacement = 'assertDirectoryDoesNotExist'; | ||
| } elseif ('assertfilenotexists' === $assertCall['loweredName']) { | ||
| $replacement = 'assertFileDoesNotExist'; | ||
| } |
There was a problem hiding this comment.
Strange that mess-detector prefers this over switch statement, not everything can be refactored to polymorphism, especially string comparison.
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7968
I assumed$fixMapis static for performance so I tried my best to keep it like that.Could not keep fixmap static, I don't know if it has impact on performace, not sure how to use benchmark