Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Test-Simple in perl blead to 1.302037 #15422

Closed
p5pRT opened this issue Jul 4, 2016 · 10 comments
Closed

Update Test-Simple in perl blead to 1.302037 #15422

p5pRT opened this issue Jul 4, 2016 · 10 comments

Comments

@p5pRT
Copy link

p5pRT commented Jul 4, 2016

Migrated from rt.perl.org#128536 (status was 'resolved')

Searchable as RT128536$

@p5pRT
Copy link
Author

p5pRT commented Jul 4, 2016

From @exodist

  Update Test-Simple to 1.302037

  This includes many bugfixes and documentation updates.

  This also fixes a notable bug where one test would pass under the
  harness, but fail when run directly under perl (due to perl RT #128530)

@p5pRT
Copy link
Author

p5pRT commented Jul 4, 2016

From @exodist

0001-Update-Test-Simple-to-1.302037.patch
From c5043eff442ae0800d34ac0edf713b5b7224718e Mon Sep 17 00:00:00 2001
From: Chad Granum <exodist7@gmail.com>
Date: Mon, 4 Jul 2016 12:36:02 -0700
Subject: [PATCH] Update Test-Simple to 1.302037

This includes many bugfixes and documentation updates.

This also fixes a notable bug where one test would pass under the
harness, but fail when run directly under perl (due to perl RT #128530)
---
 MANIFEST                                           |  2 +
 cpan/Test-Simple/lib/Test/Builder.pm               |  2 +-
 cpan/Test-Simple/lib/Test/Builder/Formatter.pm     |  2 +-
 cpan/Test-Simple/lib/Test/Builder/Module.pm        |  2 +-
 cpan/Test-Simple/lib/Test/Builder/Tester.pm        |  2 +-
 cpan/Test-Simple/lib/Test/Builder/Tester/Color.pm  |  2 +-
 cpan/Test-Simple/lib/Test/Builder/TodoDiag.pm      |  2 +-
 cpan/Test-Simple/lib/Test/More.pm                  |  2 +-
 cpan/Test-Simple/lib/Test/Simple.pm                |  2 +-
 cpan/Test-Simple/lib/Test/Tester.pm                |  2 +-
 cpan/Test-Simple/lib/Test/Tester/Capture.pm        |  2 +-
 cpan/Test-Simple/lib/Test/Tester/CaptureRunner.pm  |  2 +-
 cpan/Test-Simple/lib/Test/Tester/Delegate.pm       |  2 +-
 cpan/Test-Simple/lib/Test/use/ok.pm                |  2 +-
 cpan/Test-Simple/lib/Test2.pm                      |  2 +-
 cpan/Test-Simple/lib/Test2/API.pm                  |  2 +-
 cpan/Test-Simple/lib/Test2/API/Breakage.pm         |  2 +-
 cpan/Test-Simple/lib/Test2/API/Context.pm          |  2 +-
 cpan/Test-Simple/lib/Test2/API/Instance.pm         |  2 +-
 cpan/Test-Simple/lib/Test2/API/Stack.pm            |  2 +-
 cpan/Test-Simple/lib/Test2/Event.pm                |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Bail.pm           |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Diag.pm           |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Exception.pm      |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Generic.pm        |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Note.pm           |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Ok.pm             |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Plan.pm           |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Skip.pm           |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Subtest.pm        |  2 +-
 cpan/Test-Simple/lib/Test2/Event/Waiting.pm        |  2 +-
 cpan/Test-Simple/lib/Test2/Formatter.pm            |  2 +-
 cpan/Test-Simple/lib/Test2/Formatter/TAP.pm        | 12 ++++--
 cpan/Test-Simple/lib/Test2/Hub.pm                  |  2 +-
 cpan/Test-Simple/lib/Test2/Hub/Interceptor.pm      |  2 +-
 .../lib/Test2/Hub/Interceptor/Terminator.pm        |  2 +-
 cpan/Test-Simple/lib/Test2/Hub/Subtest.pm          |  2 +-
 cpan/Test-Simple/lib/Test2/IPC.pm                  |  2 +-
 cpan/Test-Simple/lib/Test2/IPC/Driver.pm           |  2 +-
 cpan/Test-Simple/lib/Test2/IPC/Driver/Files.pm     |  2 +-
 cpan/Test-Simple/lib/Test2/Util.pm                 |  2 +-
 cpan/Test-Simple/lib/Test2/Util/ExternalMeta.pm    |  2 +-
 cpan/Test-Simple/lib/Test2/Util/HashBase.pm        |  2 +-
 cpan/Test-Simple/lib/Test2/Util/Trace.pm           |  2 +-
 cpan/Test-Simple/lib/ok.pm                         |  2 +-
 cpan/Test-Simple/t/Legacy/subtest/plan.t           | 49 ++++++++++++++++++++++
 cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t   | 19 +++++++++
 47 files changed, 122 insertions(+), 46 deletions(-)
 create mode 100644 cpan/Test-Simple/t/Legacy/subtest/plan.t
 create mode 100644 cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t

diff --git a/MANIFEST b/MANIFEST
index 68ed19d..bc863fe 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -2666,6 +2666,7 @@ cpan/Test-Simple/t/Legacy/subtest/for_do_t.test
 cpan/Test-Simple/t/Legacy/subtest/fork.t
 cpan/Test-Simple/t/Legacy/subtest/implicit_done.t
 cpan/Test-Simple/t/Legacy/subtest/line_numbers.t
+cpan/Test-Simple/t/Legacy/subtest/plan.t
 cpan/Test-Simple/t/Legacy/subtest/predicate.t
 cpan/Test-Simple/t/Legacy/subtest/singleton.t
 cpan/Test-Simple/t/Legacy/subtest/threads.t
@@ -2736,6 +2737,7 @@ cpan/Test-Simple/t/Test2/behavior/no_load_api.t
 cpan/Test-Simple/t/Test2/behavior/run_subtest_inherit.t
 cpan/Test-Simple/t/Test2/behavior/Subtest_buffer_formatter.t
 cpan/Test-Simple/t/Test2/behavior/Subtest_events.t
+cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t
 cpan/Test-Simple/t/Test2/behavior/Taint.t
 cpan/Test-Simple/t/Test2/legacy/TAP.t
 cpan/Test-Simple/t/Test2/modules/API.t
diff --git a/cpan/Test-Simple/lib/Test/Builder.pm b/cpan/Test-Simple/lib/Test/Builder.pm
index e04dd39..401cb3c 100644
--- a/cpan/Test-Simple/lib/Test/Builder.pm
+++ b/cpan/Test-Simple/lib/Test/Builder.pm
@@ -4,7 +4,7 @@ use 5.006;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 BEGIN {
     if( $] < 5.008 ) {
diff --git a/cpan/Test-Simple/lib/Test/Builder/Formatter.pm b/cpan/Test-Simple/lib/Test/Builder/Formatter.pm
index 9b70d58..da09cb2 100644
--- a/cpan/Test-Simple/lib/Test/Builder/Formatter.pm
+++ b/cpan/Test-Simple/lib/Test/Builder/Formatter.pm
@@ -2,7 +2,7 @@ package Test::Builder::Formatter;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 BEGIN { require Test2::Formatter::TAP; our @ISA = qw(Test2::Formatter::TAP) }
 
diff --git a/cpan/Test-Simple/lib/Test/Builder/Module.pm b/cpan/Test-Simple/lib/Test/Builder/Module.pm
index 72d7bea..b2db639 100644
--- a/cpan/Test-Simple/lib/Test/Builder/Module.pm
+++ b/cpan/Test-Simple/lib/Test/Builder/Module.pm
@@ -7,7 +7,7 @@ use Test::Builder;
 require Exporter;
 our @ISA = qw(Exporter);
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 =head1 NAME
diff --git a/cpan/Test-Simple/lib/Test/Builder/Tester.pm b/cpan/Test-Simple/lib/Test/Builder/Tester.pm
index 1d93568..455ecf3 100644
--- a/cpan/Test-Simple/lib/Test/Builder/Tester.pm
+++ b/cpan/Test-Simple/lib/Test/Builder/Tester.pm
@@ -1,7 +1,7 @@
 package Test::Builder::Tester;
 
 use strict;
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 use Test::Builder;
 use Symbol;
diff --git a/cpan/Test-Simple/lib/Test/Builder/Tester/Color.pm b/cpan/Test-Simple/lib/Test/Builder/Tester/Color.pm
index 43d833c..60be59a 100644
--- a/cpan/Test-Simple/lib/Test/Builder/Tester/Color.pm
+++ b/cpan/Test-Simple/lib/Test/Builder/Tester/Color.pm
@@ -1,7 +1,7 @@
 package Test::Builder::Tester::Color;
 
 use strict;
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 require Test::Builder::Tester;
 
diff --git a/cpan/Test-Simple/lib/Test/Builder/TodoDiag.pm b/cpan/Test-Simple/lib/Test/Builder/TodoDiag.pm
index b319377..2726211 100644
--- a/cpan/Test-Simple/lib/Test/Builder/TodoDiag.pm
+++ b/cpan/Test-Simple/lib/Test/Builder/TodoDiag.pm
@@ -2,7 +2,7 @@ package Test::Builder::TodoDiag;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 BEGIN { require Test2::Event::Diag; our @ISA = qw(Test2::Event::Diag) }
 
diff --git a/cpan/Test-Simple/lib/Test/More.pm b/cpan/Test-Simple/lib/Test/More.pm
index e0c2f84..7d69e72 100644
--- a/cpan/Test-Simple/lib/Test/More.pm
+++ b/cpan/Test-Simple/lib/Test/More.pm
@@ -17,7 +17,7 @@ sub _carp {
     return warn @_, " at $file line $line\n";
 }
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 use Test::Builder::Module;
 our @ISA    = qw(Test::Builder::Module);
diff --git a/cpan/Test-Simple/lib/Test/Simple.pm b/cpan/Test-Simple/lib/Test/Simple.pm
index d0f9f06..bffc7e5 100644
--- a/cpan/Test-Simple/lib/Test/Simple.pm
+++ b/cpan/Test-Simple/lib/Test/Simple.pm
@@ -4,7 +4,7 @@ use 5.006;
 
 use strict;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 use Test::Builder::Module;
 our @ISA    = qw(Test::Builder::Module);
diff --git a/cpan/Test-Simple/lib/Test/Tester.pm b/cpan/Test-Simple/lib/Test/Tester.pm
index 88323f5..1d86981 100644
--- a/cpan/Test-Simple/lib/Test/Tester.pm
+++ b/cpan/Test-Simple/lib/Test/Tester.pm
@@ -18,7 +18,7 @@ require Exporter;
 
 use vars qw( @ISA @EXPORT );
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 @EXPORT = qw( run_tests check_tests check_test cmp_results show_space );
 @ISA = qw( Exporter );
diff --git a/cpan/Test-Simple/lib/Test/Tester/Capture.pm b/cpan/Test-Simple/lib/Test/Tester/Capture.pm
index 3eb945f..d6a4c1c 100644
--- a/cpan/Test-Simple/lib/Test/Tester/Capture.pm
+++ b/cpan/Test-Simple/lib/Test/Tester/Capture.pm
@@ -2,7 +2,7 @@ use strict;
 
 package Test::Tester::Capture;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test::Builder;
diff --git a/cpan/Test-Simple/lib/Test/Tester/CaptureRunner.pm b/cpan/Test-Simple/lib/Test/Tester/CaptureRunner.pm
index 03714fe..4a81f22 100644
--- a/cpan/Test-Simple/lib/Test/Tester/CaptureRunner.pm
+++ b/cpan/Test-Simple/lib/Test/Tester/CaptureRunner.pm
@@ -3,7 +3,7 @@ use strict;
 
 package Test::Tester::CaptureRunner;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test::Tester::Capture;
diff --git a/cpan/Test-Simple/lib/Test/Tester/Delegate.pm b/cpan/Test-Simple/lib/Test/Tester/Delegate.pm
index 7659d6b..9ace7a0 100644
--- a/cpan/Test-Simple/lib/Test/Tester/Delegate.pm
+++ b/cpan/Test-Simple/lib/Test/Tester/Delegate.pm
@@ -3,7 +3,7 @@ use warnings;
 
 package Test::Tester::Delegate;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use vars '$AUTOLOAD';
diff --git a/cpan/Test-Simple/lib/Test/use/ok.pm b/cpan/Test-Simple/lib/Test/use/ok.pm
index eca1f1c..1258906 100644
--- a/cpan/Test-Simple/lib/Test/use/ok.pm
+++ b/cpan/Test-Simple/lib/Test/use/ok.pm
@@ -1,7 +1,7 @@
 package Test::use::ok;
 use 5.005;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 __END__
diff --git a/cpan/Test-Simple/lib/Test2.pm b/cpan/Test-Simple/lib/Test2.pm
index 0ec3ddb..560bba4 100644
--- a/cpan/Test-Simple/lib/Test2.pm
+++ b/cpan/Test-Simple/lib/Test2.pm
@@ -2,7 +2,7 @@ package Test2;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 1;
diff --git a/cpan/Test-Simple/lib/Test2/API.pm b/cpan/Test-Simple/lib/Test2/API.pm
index 27c17b3..31b0d0f 100644
--- a/cpan/Test-Simple/lib/Test2/API.pm
+++ b/cpan/Test-Simple/lib/Test2/API.pm
@@ -2,7 +2,7 @@ package Test2::API;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 my $INST;
diff --git a/cpan/Test-Simple/lib/Test2/API/Breakage.pm b/cpan/Test-Simple/lib/Test2/API/Breakage.pm
index 75e9faa..049446d 100644
--- a/cpan/Test-Simple/lib/Test2/API/Breakage.pm
+++ b/cpan/Test-Simple/lib/Test2/API/Breakage.pm
@@ -2,7 +2,7 @@ package Test2::API::Breakage;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test2::Util qw/pkg_to_file/;
diff --git a/cpan/Test-Simple/lib/Test2/API/Context.pm b/cpan/Test-Simple/lib/Test2/API/Context.pm
index 64bc254..8281401 100644
--- a/cpan/Test-Simple/lib/Test2/API/Context.pm
+++ b/cpan/Test-Simple/lib/Test2/API/Context.pm
@@ -2,7 +2,7 @@ package Test2::API::Context;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Carp qw/confess croak longmess/;
diff --git a/cpan/Test-Simple/lib/Test2/API/Instance.pm b/cpan/Test-Simple/lib/Test2/API/Instance.pm
index ca50fb9..712e193 100644
--- a/cpan/Test-Simple/lib/Test2/API/Instance.pm
+++ b/cpan/Test-Simple/lib/Test2/API/Instance.pm
@@ -2,7 +2,7 @@ package Test2::API::Instance;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 our @CARP_NOT = qw/Test2::API Test2::API::Instance Test2::IPC::Driver Test2::Formatter/;
diff --git a/cpan/Test-Simple/lib/Test2/API/Stack.pm b/cpan/Test-Simple/lib/Test2/API/Stack.pm
index e699f03..fa85f62 100644
--- a/cpan/Test-Simple/lib/Test2/API/Stack.pm
+++ b/cpan/Test-Simple/lib/Test2/API/Stack.pm
@@ -2,7 +2,7 @@ package Test2::API::Stack;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test2::Hub();
diff --git a/cpan/Test-Simple/lib/Test2/Event.pm b/cpan/Test-Simple/lib/Test2/Event.pm
index db4f4df..1b0cac0 100644
--- a/cpan/Test-Simple/lib/Test2/Event.pm
+++ b/cpan/Test-Simple/lib/Test2/Event.pm
@@ -2,7 +2,7 @@ package Test2::Event;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test2::Util::HashBase qw/trace nested in_subtest subtest_id/;
diff --git a/cpan/Test-Simple/lib/Test2/Event/Bail.pm b/cpan/Test-Simple/lib/Test2/Event/Bail.pm
index 47d05a1..00e7ffc 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Bail.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Bail.pm
@@ -2,7 +2,7 @@ package Test2::Event::Bail;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event; our @ISA = qw(Test2::Event) }
diff --git a/cpan/Test-Simple/lib/Test2/Event/Diag.pm b/cpan/Test-Simple/lib/Test2/Event/Diag.pm
index 5b3f685..e825d73 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Diag.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Diag.pm
@@ -2,7 +2,7 @@ package Test2::Event::Diag;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event; our @ISA = qw(Test2::Event) }
diff --git a/cpan/Test-Simple/lib/Test2/Event/Exception.pm b/cpan/Test-Simple/lib/Test2/Event/Exception.pm
index a5f3071..70ace48 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Exception.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Exception.pm
@@ -2,7 +2,7 @@ package Test2::Event::Exception;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event; our @ISA = qw(Test2::Event) }
diff --git a/cpan/Test-Simple/lib/Test2/Event/Generic.pm b/cpan/Test-Simple/lib/Test2/Event/Generic.pm
index 91cd9f3..78ec6df 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Generic.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Generic.pm
@@ -5,7 +5,7 @@ use warnings;
 use Carp qw/croak/;
 use Scalar::Util qw/reftype/;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 BEGIN { require Test2::Event; our @ISA = qw(Test2::Event) }
 use Test2::Util::HashBase;
diff --git a/cpan/Test-Simple/lib/Test2/Event/Note.pm b/cpan/Test-Simple/lib/Test2/Event/Note.pm
index a0395fe..4e24e54 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Note.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Note.pm
@@ -2,7 +2,7 @@ package Test2::Event::Note;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event; our @ISA = qw(Test2::Event) }
diff --git a/cpan/Test-Simple/lib/Test2/Event/Ok.pm b/cpan/Test-Simple/lib/Test2/Event/Ok.pm
index 386a86b..9ccd7cb 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Ok.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Ok.pm
@@ -2,7 +2,7 @@ package Test2::Event::Ok;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event; our @ISA = qw(Test2::Event) }
diff --git a/cpan/Test-Simple/lib/Test2/Event/Plan.pm b/cpan/Test-Simple/lib/Test2/Event/Plan.pm
index a0bee2f..56b99f1 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Plan.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Plan.pm
@@ -2,7 +2,7 @@ package Test2::Event::Plan;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event; our @ISA = qw(Test2::Event) }
diff --git a/cpan/Test-Simple/lib/Test2/Event/Skip.pm b/cpan/Test-Simple/lib/Test2/Event/Skip.pm
index 5b446ef..b1f9614 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Skip.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Skip.pm
@@ -2,7 +2,7 @@ package Test2::Event::Skip;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event::Ok; our @ISA = qw(Test2::Event::Ok) }
diff --git a/cpan/Test-Simple/lib/Test2/Event/Subtest.pm b/cpan/Test-Simple/lib/Test2/Event/Subtest.pm
index 49b827f..28efaba 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Subtest.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Subtest.pm
@@ -2,7 +2,7 @@ package Test2::Event::Subtest;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event::Ok; our @ISA = qw(Test2::Event::Ok) }
diff --git a/cpan/Test-Simple/lib/Test2/Event/Waiting.pm b/cpan/Test-Simple/lib/Test2/Event/Waiting.pm
index ee526bb..4fc5ed3 100644
--- a/cpan/Test-Simple/lib/Test2/Event/Waiting.pm
+++ b/cpan/Test-Simple/lib/Test2/Event/Waiting.pm
@@ -2,7 +2,7 @@ package Test2::Event::Waiting;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Event; our @ISA = qw(Test2::Event) }
diff --git a/cpan/Test-Simple/lib/Test2/Formatter.pm b/cpan/Test-Simple/lib/Test2/Formatter.pm
index c4b0682..f83bb7c 100644
--- a/cpan/Test-Simple/lib/Test2/Formatter.pm
+++ b/cpan/Test-Simple/lib/Test2/Formatter.pm
@@ -2,7 +2,7 @@ package Test2::Formatter;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 my %ADDED;
diff --git a/cpan/Test-Simple/lib/Test2/Formatter/TAP.pm b/cpan/Test-Simple/lib/Test2/Formatter/TAP.pm
index 900dae0..a610f45 100644
--- a/cpan/Test-Simple/lib/Test2/Formatter/TAP.pm
+++ b/cpan/Test-Simple/lib/Test2/Formatter/TAP.pm
@@ -1,8 +1,9 @@
 package Test2::Formatter::TAP;
 use strict;
 use warnings;
+require PerlIO;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test2::Util::HashBase qw{
@@ -108,8 +109,13 @@ sub write {
 sub _open_handles {
     my $self = shift;
 
-    open( my $out, '>&', STDOUT ) or die "Can't dup STDOUT:  $!";
-    open( my $err, '>&', STDERR ) or die "Can't dup STDERR:  $!";
+    my %seen;
+    open(my $out, '>&', STDOUT) or die "Can't dup STDOUT:  $!";
+    binmode($out, join(":", "", "raw", grep { $_ ne 'unix' and !$seen{$_}++ } PerlIO::get_layers(STDOUT)));
+
+    %seen = ();
+    open(my $err, '>&', STDERR) or die "Can't dup STDERR:  $!";
+    binmode($err, join(":", "", "raw", grep { $_ ne 'unix' and !$seen{$_}++ } PerlIO::get_layers(STDERR)));
 
     _autoflush($out);
     _autoflush($err);
diff --git a/cpan/Test-Simple/lib/Test2/Hub.pm b/cpan/Test-Simple/lib/Test2/Hub.pm
index 40b6c19..89a04f0 100644
--- a/cpan/Test-Simple/lib/Test2/Hub.pm
+++ b/cpan/Test-Simple/lib/Test2/Hub.pm
@@ -2,7 +2,7 @@ package Test2::Hub;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Carp qw/carp croak confess/;
diff --git a/cpan/Test-Simple/lib/Test2/Hub/Interceptor.pm b/cpan/Test-Simple/lib/Test2/Hub/Interceptor.pm
index 1b223dd..4e98aea 100644
--- a/cpan/Test-Simple/lib/Test2/Hub/Interceptor.pm
+++ b/cpan/Test-Simple/lib/Test2/Hub/Interceptor.pm
@@ -2,7 +2,7 @@ package Test2::Hub::Interceptor;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test2::Hub::Interceptor::Terminator();
diff --git a/cpan/Test-Simple/lib/Test2/Hub/Interceptor/Terminator.pm b/cpan/Test-Simple/lib/Test2/Hub/Interceptor/Terminator.pm
index 44a220a..00af99f 100644
--- a/cpan/Test-Simple/lib/Test2/Hub/Interceptor/Terminator.pm
+++ b/cpan/Test-Simple/lib/Test2/Hub/Interceptor/Terminator.pm
@@ -2,7 +2,7 @@ package Test2::Hub::Interceptor::Terminator;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 1;
diff --git a/cpan/Test-Simple/lib/Test2/Hub/Subtest.pm b/cpan/Test-Simple/lib/Test2/Hub/Subtest.pm
index a11fc91..a050a75 100644
--- a/cpan/Test-Simple/lib/Test2/Hub/Subtest.pm
+++ b/cpan/Test-Simple/lib/Test2/Hub/Subtest.pm
@@ -2,7 +2,7 @@ package Test2::Hub::Subtest;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::Hub; our @ISA = qw(Test2::Hub) }
diff --git a/cpan/Test-Simple/lib/Test2/IPC.pm b/cpan/Test-Simple/lib/Test2/IPC.pm
index 01d3cd8..4ceed43 100644
--- a/cpan/Test-Simple/lib/Test2/IPC.pm
+++ b/cpan/Test-Simple/lib/Test2/IPC.pm
@@ -2,7 +2,7 @@ package Test2::IPC;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test2::API::Instance;
diff --git a/cpan/Test-Simple/lib/Test2/IPC/Driver.pm b/cpan/Test-Simple/lib/Test2/IPC/Driver.pm
index 5878d75..0df7b50 100644
--- a/cpan/Test-Simple/lib/Test2/IPC/Driver.pm
+++ b/cpan/Test-Simple/lib/Test2/IPC/Driver.pm
@@ -2,7 +2,7 @@ package Test2::IPC::Driver;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Carp qw/confess longmess/;
diff --git a/cpan/Test-Simple/lib/Test2/IPC/Driver/Files.pm b/cpan/Test-Simple/lib/Test2/IPC/Driver/Files.pm
index acf0342..e7ff407 100644
--- a/cpan/Test-Simple/lib/Test2/IPC/Driver/Files.pm
+++ b/cpan/Test-Simple/lib/Test2/IPC/Driver/Files.pm
@@ -2,7 +2,7 @@ package Test2::IPC::Driver::Files;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 BEGIN { require Test2::IPC::Driver; our @ISA = qw(Test2::IPC::Driver) }
diff --git a/cpan/Test-Simple/lib/Test2/Util.pm b/cpan/Test-Simple/lib/Test2/Util.pm
index b991727..49d0499 100644
--- a/cpan/Test-Simple/lib/Test2/Util.pm
+++ b/cpan/Test-Simple/lib/Test2/Util.pm
@@ -2,7 +2,7 @@ package Test2::Util;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Config qw/%Config/;
diff --git a/cpan/Test-Simple/lib/Test2/Util/ExternalMeta.pm b/cpan/Test-Simple/lib/Test2/Util/ExternalMeta.pm
index c55196f..54d675b 100644
--- a/cpan/Test-Simple/lib/Test2/Util/ExternalMeta.pm
+++ b/cpan/Test-Simple/lib/Test2/Util/ExternalMeta.pm
@@ -2,7 +2,7 @@ package Test2::Util::ExternalMeta;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Carp qw/croak/;
diff --git a/cpan/Test-Simple/lib/Test2/Util/HashBase.pm b/cpan/Test-Simple/lib/Test2/Util/HashBase.pm
index be76393..5b6d1e0 100644
--- a/cpan/Test-Simple/lib/Test2/Util/HashBase.pm
+++ b/cpan/Test-Simple/lib/Test2/Util/HashBase.pm
@@ -2,7 +2,7 @@ package Test2::Util::HashBase;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 require Carp;
diff --git a/cpan/Test-Simple/lib/Test2/Util/Trace.pm b/cpan/Test-Simple/lib/Test2/Util/Trace.pm
index c5c7bec..3c20d90 100644
--- a/cpan/Test-Simple/lib/Test2/Util/Trace.pm
+++ b/cpan/Test-Simple/lib/Test2/Util/Trace.pm
@@ -2,7 +2,7 @@ package Test2::Util::Trace;
 use strict;
 use warnings;
 
-our $VERSION = '1.302035';
+our $VERSION = '1.302037';
 
 
 use Test2::Util qw/get_tid/;
diff --git a/cpan/Test-Simple/lib/ok.pm b/cpan/Test-Simple/lib/ok.pm
index d05feaf..ce019a7 100644
--- a/cpan/Test-Simple/lib/ok.pm
+++ b/cpan/Test-Simple/lib/ok.pm
@@ -1,5 +1,5 @@
 package ok;
-$ok::VERSION = '1.302035';
+$ok::VERSION = '1.302037';
 
 use strict;
 use Test::More ();
diff --git a/cpan/Test-Simple/t/Legacy/subtest/plan.t b/cpan/Test-Simple/t/Legacy/subtest/plan.t
new file mode 100644
index 0000000..7e944ab
--- /dev/null
+++ b/cpan/Test-Simple/t/Legacy/subtest/plan.t
@@ -0,0 +1,49 @@
+#!/usr/bin/perl -w
+
+BEGIN {
+    if( $ENV{PERL_CORE} ) {
+        chdir 't';
+        @INC = ( '../lib', 'lib' );
+    }
+    else {
+        unshift @INC, 't/lib';
+    }
+}
+
+use strict;
+use warnings;
+
+use Test::Builder::NoOutput;
+
+use Test::More tests => 6;
+
+# Formatting may change if we're running under Test::Harness.
+$ENV{HARNESS_ACTIVE} = 0;
+
+{
+    ok defined &subtest, 'subtest() should be exported to our namespace';
+    is prototype('subtest'), undef, '... has no prototype';
+
+    subtest 'subtest with plan', sub {
+        plan tests => 2;
+        ok 1, 'planned subtests should work';
+        ok 1, '... and support more than one test';
+    };
+    subtest 'subtest without plan', sub {
+        plan 'no_plan';
+        ok 1, 'no_plan subtests should work';
+        ok 1, '... and support more than one test';
+        ok 1, '... no matter how many tests are run';
+    };
+    subtest 'subtest with implicit done_testing()', sub {
+        ok 1, 'subtests with an implicit done testing should work';
+        ok 1, '... and support more than one test';
+        ok 1, '... no matter how many tests are run';
+    };
+    subtest 'subtest with explicit done_testing()', sub {
+        ok 1, 'subtests with an explicit done testing should work';
+        ok 1, '... and support more than one test';
+        ok 1, '... no matter how many tests are run';
+        done_testing();
+    };
+}
diff --git a/cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t b/cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t
new file mode 100644
index 0000000..f3dab3c
--- /dev/null
+++ b/cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t
@@ -0,0 +1,19 @@
+use strict;
+use warnings;
+
+BEGIN { require "t/tools.pl" };
+
+use Test2::API qw/run_subtest intercept/;
+
+my $events = intercept {
+    my $code = sub { plan 4; ok(1) };
+    run_subtest('bad_plan', $code, 'buffered');
+};
+
+is(
+    $events->[-1]->message,
+    "Bad subtest plan, expected 4 but ran 1",
+    "Helpful message if subtest has a bad plan",
+);
+
+done_testing;
-- 
2.8.2

@p5pRT
Copy link
Author

p5pRT commented Jul 4, 2016

From @jkeenan

On Mon Jul 04 13​:01​:46 2016, exodist7@​gmail.com wrote​:

Update Test\-Simple to 1\.302037

This includes many bugfixes and documentation updates\.

This also fixes a notable bug where one test would pass under the
harness\, but fail when run directly under perl \(due to perl RT \#128530\)

Pushed to blead in commit af4acf8e9207b1e3f015d93d8e1d58bb5ab70ec8.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Jul 4, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT p5pRT closed this as completed Jul 4, 2016
@p5pRT
Copy link
Author

p5pRT commented Jul 4, 2016

@jkeenan - Status changed from 'open' to 'resolved'

@p5pRT
Copy link
Author

p5pRT commented Jul 5, 2016

From @steve-m-hay

On 4 July 2016 at 22​:23, James E Keenan via RT
<perlbug-followup@​perl.org> wrote​:

On Mon Jul 04 13​:01​:46 2016, exodist7@​gmail.com wrote​:

Update Test\-Simple to 1\.302037

This includes many bugfixes and documentation updates\.

This also fixes a notable bug where one test would pass under the
harness\, but fail when run directly under perl \(due to perl RT \#128530\)

Pushed to blead in commit af4acf8e9207b1e3f015d93d8e1d58bb5ab70ec8.

Thank you very much.

This patch has reinstated two files
(cpan/Test-Simple/t/Legacy/subtest/plan.t and
cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t) that I removed in
721a029 because they weren't in the CPAN tarball.

They still aren't in the CPAN tarball, so I'm wondering why they've
been put back?

@p5pRT
Copy link
Author

p5pRT commented Jul 5, 2016

From @exodist

If they are not in the cpan tarball then that is a bug in Test-Simple. They
are in git, and I have no idea why they would be missing from the tarball.

On Tue, Jul 5, 2016 at 12​:14 AM, Steve Hay via perl5-porters <
perl5-porters@​perl.org> wrote​:

On 4 July 2016 at 22​:23, James E Keenan via RT
<perlbug-followup@​perl.org> wrote​:

On Mon Jul 04 13​:01​:46 2016, exodist7@​gmail.com wrote​:

Update Test\-Simple to 1\.302037

This includes many bugfixes and documentation updates\.

This also fixes a notable bug where one test would pass under the
harness\, but fail when run directly under perl \(due to perl RT

#128530)

Pushed to blead in commit af4acf8e9207b1e3f015d93d8e1d58bb5ab70ec8.

Thank you very much.

This patch has reinstated two files
(cpan/Test-Simple/t/Legacy/subtest/plan.t and
cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t) that I removed in
721a029 because they weren't in the CPAN tarball.

They still aren't in the CPAN tarball, so I'm wondering why they've
been put back?

@p5pRT
Copy link
Author

p5pRT commented Jul 5, 2016

From @exodist

Ok, I can confirm that when I run 'dzil build' that those files do not make
it into the build dir/tarball. Plenty of other files with subtest and/or
plan in the name make it in though. I don't see anything in MANIFEST.SKIP
or dist.ini that would prevent these files from making it though....

This may take a little longer to figure out....

-Chad

On Tue, Jul 5, 2016 at 6​:34 AM, Chad Granum <exodist7@​gmail.com> wrote​:

If they are not in the cpan tarball then that is a bug in Test-Simple.
They are in git, and I have no idea why they would be missing from the
tarball.

On Tue, Jul 5, 2016 at 12​:14 AM, Steve Hay via perl5-porters <
perl5-porters@​perl.org> wrote​:

On 4 July 2016 at 22​:23, James E Keenan via RT
<perlbug-followup@​perl.org> wrote​:

On Mon Jul 04 13​:01​:46 2016, exodist7@​gmail.com wrote​:

Update Test\-Simple to 1\.302037

This includes many bugfixes and documentation updates\.

This also fixes a notable bug where one test would pass under the
harness\, but fail when run directly under perl \(due to perl RT

#128530)

Pushed to blead in commit af4acf8e9207b1e3f015d93d8e1d58bb5ab70ec8.

Thank you very much.

This patch has reinstated two files
(cpan/Test-Simple/t/Legacy/subtest/plan.t and
cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t) that I removed in
721a029 because they weren't in the CPAN tarball.

They still aren't in the CPAN tarball, so I'm wondering why they've
been put back?

@p5pRT
Copy link
Author

p5pRT commented Jul 5, 2016

From @exodist

Test-More/test-more#689

Added to track this.

On Tue, Jul 5, 2016 at 6​:39 AM, Chad Granum <exodist7@​gmail.com> wrote​:

Ok, I can confirm that when I run 'dzil build' that those files do not
make it into the build dir/tarball. Plenty of other files with subtest
and/or plan in the name make it in though. I don't see anything in
MANIFEST.SKIP or dist.ini that would prevent these files from making it
though....

This may take a little longer to figure out....

-Chad

On Tue, Jul 5, 2016 at 6​:34 AM, Chad Granum <exodist7@​gmail.com> wrote​:

If they are not in the cpan tarball then that is a bug in Test-Simple.
They are in git, and I have no idea why they would be missing from the
tarball.

On Tue, Jul 5, 2016 at 12​:14 AM, Steve Hay via perl5-porters <
perl5-porters@​perl.org> wrote​:

On 4 July 2016 at 22​:23, James E Keenan via RT
<perlbug-followup@​perl.org> wrote​:

On Mon Jul 04 13​:01​:46 2016, exodist7@​gmail.com wrote​:

Update Test\-Simple to 1\.302037

This includes many bugfixes and documentation updates\.

This also fixes a notable bug where one test would pass under the
harness\, but fail when run directly under perl \(due to perl RT

#128530)

Pushed to blead in commit af4acf8e9207b1e3f015d93d8e1d58bb5ab70ec8.

Thank you very much.

This patch has reinstated two files
(cpan/Test-Simple/t/Legacy/subtest/plan.t and
cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t) that I removed in
721a029 because they weren't in the CPAN tarball.

They still aren't in the CPAN tarball, so I'm wondering why they've
been put back?

@p5pRT
Copy link
Author

p5pRT commented Jul 5, 2016

From @exodist

Figured out the issue, a bug in MANIFEST.SKIP (. instead of \.) and have
fixed it.

I released a -TRIAL to cpan with the changes (so the tests are now
included) the only practical difference in the tarball is that the tests
are no longer missing.

After a day or 2 I will release a stable version that has the tests and
submit a patch to p5p.

Next time files seem missing please let me know, chances are I screwed up
and need a report.

On Tue, Jul 5, 2016 at 6​:44 AM, Chad Granum <exodist7@​gmail.com> wrote​:

Test-More/test-more#689

Added to track this.

On Tue, Jul 5, 2016 at 6​:39 AM, Chad Granum <exodist7@​gmail.com> wrote​:

Ok, I can confirm that when I run 'dzil build' that those files do not
make it into the build dir/tarball. Plenty of other files with subtest
and/or plan in the name make it in though. I don't see anything in
MANIFEST.SKIP or dist.ini that would prevent these files from making it
though....

This may take a little longer to figure out....

-Chad

On Tue, Jul 5, 2016 at 6​:34 AM, Chad Granum <exodist7@​gmail.com> wrote​:

If they are not in the cpan tarball then that is a bug in Test-Simple.
They are in git, and I have no idea why they would be missing from the
tarball.

On Tue, Jul 5, 2016 at 12​:14 AM, Steve Hay via perl5-porters <
perl5-porters@​perl.org> wrote​:

On 4 July 2016 at 22​:23, James E Keenan via RT
<perlbug-followup@​perl.org> wrote​:

On Mon Jul 04 13​:01​:46 2016, exodist7@​gmail.com wrote​:

Update Test\-Simple to 1\.302037

This includes many bugfixes and documentation updates\.

This also fixes a notable bug where one test would pass under the
harness\, but fail when run directly under perl \(due to perl RT

#128530)

Pushed to blead in commit af4acf8e9207b1e3f015d93d8e1d58bb5ab70ec8.

Thank you very much.

This patch has reinstated two files
(cpan/Test-Simple/t/Legacy/subtest/plan.t and
cpan/Test-Simple/t/Test2/behavior/Subtest_plan.t) that I removed in
721a029 because they weren't in the CPAN tarball.

They still aren't in the CPAN tarball, so I'm wondering why they've
been put back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant