This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
OS X dylib relocation #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine. I read about the Mac OS X specifics as applied to other projects and this is a reasonable solution. Merge: Aye |
|
This was the solution that I had avoided for so long. My goal was to keep this as platform agnostic as I possibly could. If we have determined that that is no longer possible, then reluctantly (and with my thanks for not making me code it), aye. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the dynamic library relocation issue mentioned by @jberger by correcting the .dylib file's id field. I tested this with
Alien::EditlineandTerm::EditLineby settingalien_isoloate_dynamicto0, andalien_stage_installto1. This allowed me to reproduce the problem, and correct it.