This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
Test success on version probe #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes the command would have to succeed in order to provide useful results I suppose. Aye |
|
Currently I am finding it very difficult to make time for open-source stuff. What if we switch our merge policy from "two ayes" to "one aye plus some short delay"? |
|
@mohawk2 this is more or less what I have been doing, although "short delay" is seven days. I am happy with this pace. |
|
Works for me! I'm also reassured that I'm not holding things up. |
If the command fails, but there is some output we get a false positive. This problem was discovered when using perl Build.PL verbose=1 (and demonstrated with Alien::LibYAML). While this exact problem will hopefully be fixed with PR #147, there are other strangeisms that could infect the captured output with bogus data.
plicease
force-pushed
the
check_exit_status
branch
from
c64afa7
to
cff2ec8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the command fails, but there is some output we get a false positive. This problem was discovered when using perl Build.PL verbose=1 (and demonstrated with Alien::LibYAML). While this exact problem
will hopefully be fixed with PR #147, there are other strangeisms that could infect the captured output with bogus data.