Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Allow overriding repo config from ENV #180

Closed
wants to merge 2 commits into from
Closed

Conversation

nshp
Copy link
Contributor

@nshp nshp commented Feb 2, 2017

Allows e.g.:

ALIEN_OPENSSL_REPO_FTP_HOST=example.com cpanm Alien::OpenSSL

@wbraswell
Copy link

Seems legit?

@plicease
Copy link
Contributor

plicease commented Feb 3, 2017

Going to do some testing, but I think I largely approve. I appreciate the documentation on the environment variables, which are also buried in the documentation here:

https://metacpan.org/pod/distribution/Alien-Base/lib/Alien/Base/ModuleBuild/API.pod#PACKAGE-AND-ENVIRONMENT-VARIABLES

@plicease
Copy link
Contributor

plicease commented Feb 7, 2017

I did some testing with my own Alien::FFI, and I vote for inclusion. I will merge this Thursday if there aren't any objections before then.

@plicease
Copy link
Contributor

plicease commented Feb 9, 2017

Rebased and merged. I am going to send this to CPAN now.

@plicease plicease closed this Feb 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants