Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

make --with-pic default for autoconf #47

Merged
merged 3 commits into from Sep 4, 2014
Merged

make --with-pic default for autoconf #47

merged 3 commits into from Sep 4, 2014

Conversation

plicease
Copy link
Contributor

Add --with-pic to the default autoconf build.

This enables position independent code to be generated, which is necessary when using static libraries to build Foo.so (for Alien::Foo). At the moment this is only useful if the packages does not build a dynamic library by default, but it may also be necessary if the static libs become the default (see #11). I am creating this as a PR to open discussion on this specific part of #11.

Note that this conflicts with #46, and I will adjust this PR if both are accepted.

@plicease
Copy link
Contributor Author

It may also make more sense to add --with-pic to %c (assuming #46 goes). ie %c = ./configure --with-pic. It makes it hard to turn off of course if you really need to.

@mohawk2
Copy link
Contributor

mohawk2 commented Aug 30, 2014

If you doc that it's a platform-suitable way of running configure, and it works, that seems like a win. (You're going to need to update with the #46 merge)

@plicease
Copy link
Contributor Author

I think it requires that libtool being used:

http://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html

However, I believe this like all other options gets silently ignored if they aren't supported.

@mohawk2
Copy link
Contributor

mohawk2 commented Aug 30, 2014

I'm keen to see some sort of test that can be exercised in the next dev release across the smoke-test network.

@jberger
Copy link
Member

jberger commented Aug 31, 2014

Most of the actual use-case testing is done via two Acme distros I that I have for this purpose. Acme::Alien::DontPanic and Acme::Ford::Prefect, which are both in the extras repo.

@plicease
Copy link
Contributor Author

plicease commented Sep 2, 2014

Updated this PR to work with the current version of AB

@mohawk2
Copy link
Contributor

mohawk2 commented Sep 3, 2014

I vote "aye". Does Travis testing imply we ought to re-incorporate the Acme test modules, or am I missing the point of splitting it out?

@plicease
Copy link
Contributor Author

plicease commented Sep 4, 2014

I am sort of okay leaving them separate?

The way I set it up is push to Alien-Base-Extras tests the dontpanic stuff with cpan version of Alien::Base and pushing to Alien-Base tests Alien-Base with the versions of dontpanic from git.

I am open to doing things differently if it makes sense.

@mohawk2
Copy link
Contributor

mohawk2 commented Sep 4, 2014

If the Travis testing "just works", I see no reason to change it.

@zmughal
Copy link
Member

zmughal commented Sep 4, 2014

Hmm, why not add another property like: autoconf_with_pic which modifies the meaning of %c (defaults to true).

I note this because there are some libraries out there that use the same convention of using a configure script, but don't use autoconf (one example that I've seen is WFDB which has a custom configure script). Passing it --with-pic causes the configure script to print a usage message. %c is still useful there.

@mohawk2
Copy link
Contributor

mohawk2 commented Sep 4, 2014

Once @zmughal is happy with this, I will be too.

@plicease plicease mentioned this pull request Sep 4, 2014
@plicease
Copy link
Contributor Author

plicease commented Sep 4, 2014

I agree that makes it better. And I am glad to make it the default. @zmughal if you are good with this we can merge it.

@zmughal
Copy link
Member

zmughal commented Sep 4, 2014

Looks good.

Merge: Aye

zmughal added a commit that referenced this pull request Sep 4, 2014
make --with-pic default for autoconf
@zmughal zmughal merged commit d2c17eb into Perl5-Alien:master Sep 4, 2014
@plicease plicease deleted the with_pic branch September 4, 2014 14:43
plicease pushed a commit that referenced this pull request Jul 17, 2017
make --with-pic default for autoconf
plicease pushed a commit that referenced this pull request Jul 17, 2017
make --with-pic default for autoconf
plicease pushed a commit that referenced this pull request Jul 17, 2017
make --with-pic default for autoconf
plicease pushed a commit that referenced this pull request Jul 17, 2017
make --with-pic default for autoconf
plicease pushed a commit that referenced this pull request Jul 17, 2017
make --with-pic default for autoconf
plicease pushed a commit that referenced this pull request Jul 17, 2017
Alien-Base: 
Alien-Base: make --with-pic default for autoconf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants