This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
Mswin32 paths #64
Merged
Mswin32 paths #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows accepts \ or / as path separators, and uses \ as the "default" (this File::Spec uses it as its default). This is problematic for shell commands as \ gets confused as an escape charater at various levels.
|
I vote: Aye on this. |
|
If it works, aye. |
|
@mohawk2 Tested this manually on MSWin32 and Debian Linux 7 |
|
This does look good. I'm going to test all these changes on one of my Alien dists for Windows later this week. Merge: Aye |
plicease
pushed a commit
that referenced
this pull request
Jul 17, 2017
Alien-Base: Alien-Base: Mswin32 paths
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some testing with 0.004_02 on MSWin32 and ran into these two problems: