This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
DESTDIR support #65
Merged
DESTDIR support #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unlink doesn't do anything to a directory / folder on most platforms so use rmtree. This is probably overkill anyway since the directories shouldn't exist if the test passes
Closed
|
Looks ok. Aye. |
| use File::Copy qw( copy ); | ||
|
|
||
| my $cmd = shift; | ||
| @ARGV = grep { s/DESTDIR/$ENV{DESTDIR}/eg; $_ } @ARGV; |
There was a problem hiding this comment.
This is modifying $_ in a grep. Might be nicer as for.
There was a problem hiding this comment.
Actually... should that be a /e? It seems like perl-evaluating the env var isn't right?
There was a problem hiding this comment.
Should be a map not grep, will update the branch.
|
Merge: Aye Looks good and that RPM is awesome! I kinda feel that I'd like to have a note in |
also the /e is unnecessary in this case
|
@zmughal added some commentary. |
plicease
added a commit
that referenced
this pull request
Jul 17, 2017
Alien-Base: Alien-Base: DESTDIR support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #39
also noted a documentation error when I was reviewing the documentation in writing the test.
In addition to the unit test, I was able to build rpms in OBS for both Acme::Alien::DontPanic and Acme::Ford::Prefect
https://build.opensuse.org/project/show/home:platypus:Alien-Base