Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voronoi Close Cells Error #32

Closed
wassfila opened this issue Apr 13, 2020 · 2 comments
Closed

Voronoi Close Cells Error #32

wassfila opened this issue Apr 13, 2020 · 2 comments

Comments

@wassfila
Copy link

wassfila commented Apr 13, 2020

Hi @PieceMaker ,
regarding this error you mention on your readme, I suggest that you have a look at this very similar issue
gorhill/Javascript-Voronoi#27 (comment)
that I solved by adjusting the epsilon paramter, I don't say this will definitely solve your issue but it's worth the try.

@PieceMaker
Copy link
Owner

Thanks for the heads up! I believe the epsilon parameter was discussed in gorhill/Javascript-Voronoi#15 as well. In that issue it looked like the choice of epsilon that caused the calculation to succeed was still dependent on the input sites. Additionally, I was reluctant to write code that redefined parts of the Voronoi prototype. Therefore I decided to expose my own version of epsilon in the form of options.decimalPlaces and leave it to the user's discretion whether to employ it and at what value.

@wassfila
Copy link
Author

That's a nice way out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants