Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge PMArbitraryPrecisionFloatForTrigonometry with PMArbitraryPrecisionFloat #197

Open
SergeStinckwich opened this issue Feb 28, 2021 · 4 comments
Open

Merge PMArbitraryPrecisionFloatForTrigonometry with PMArbitraryPrecisionFloat #197

SergeStinckwich opened this issue Feb 28, 2021 · 4 comments
Assignees
@nicolas-cellier-aka-nice
Labels
Priority: Low Status: Available Type: Question

Comments

@SergeStinckwich
Copy link
Member

@nicolas-cellier-aka-nice why do we need a separate class only for sin, cos and pi for arbitrary precision floatPMArbitraryPrecisionFloatForTrigonometry? I think we can merge with PMArbitraryPrecisionFloat to avoid confusion.
@nicolas-cellier-aka-nice
Copy link
Contributor

Yes, good idea, the only thing to care of is the precision of pi used in the subclass.

@SergeStinckwich
Copy link
Member Author

Do you mind to do a PR with this modification? Thank you.

@nicolas-cellier-aka-nice
Copy link
Contributor

I've implemented upstream, see issue #199

@SergeStinckwich
Copy link
Member Author

SergeStinckwich commented Feb 28, 2021 •
edited

ok thank you. I have to see how to see the changes between the upstream and the PM version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolas-cellier-aka-nice nicolas-cellier-aka-nice

Labels
Priority: Low Status: Available Type: Question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SergeStinckwich @nicolas-cellier-aka-nice