Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion with hardwere reserved memory laptops. #426

Closed
1 task done
Edgars-Cirulis opened this issue Nov 9, 2022 · 4 comments · Fixed by #436
Closed
1 task done

Suggestion with hardwere reserved memory laptops. #426

Edgars-Cirulis opened this issue Nov 9, 2022 · 4 comments · Fixed by #436
Labels
enhancement New feature or request
Milestone

Comments

@Edgars-Cirulis
Copy link
Contributor

Edgars-Cirulis commented Nov 9, 2022

Role

To be simple / play modpacks.

Suggestion

A checkbox that bypass a checkJVMArgs()

Benefit

So I can finnaly use PrismLauncher instead of GDLauncher.

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

The main issue is blocked JVM Args,
My hardwere has 6.9 GB Ram because 1.1 is hardwere reserved I am using zram for extra ram.

I am alaways using -Xmx -Xms args to allocate memory higher then 6.9. Some modpacks will crash unlikly if I dont allocate 8 GB Ram (Tested with Project Ozone 3) thats modpack is RAM Hungry.

Sorry for my bad english.

@Edgars-Cirulis Edgars-Cirulis added the enhancement New feature or request label Nov 9, 2022
@Frontear
Copy link

Frontear commented Nov 9, 2022

Can you explain what you mean by skipping the "checkJVMArgs()"? What does GDLauncher do here that you're asking for

@ghost
Copy link

ghost commented Nov 9, 2022

Can you explain what you mean by skipping the "checkJVMArgs()"? What does GDLauncher do here that you're asking for

The launcher stops him from allocating more than 6.9 GB of his 8 GB ram because 1.1 GB is hardware reserved. So he tried using the -Xmx -Xms JVM args to allocate it but the launcher doesn't let him do that aswell
image

@Edgars-Cirulis
Copy link
Contributor Author

Can you explain what you mean by skipping the "checkJVMArgs()"? What does GDLauncher do here that you're asking for

That's a bool in source code where it checks whenever you use JVM Args.

@Scrumplex
Copy link
Member

We can keep this open. It will be closed automatically, once #436 is merged

@Scrumplex Scrumplex reopened this Nov 11, 2022
@Scrumplex Scrumplex added this to the 6.0 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants