Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Datepicker to Flatpickr #405

Open
ooduor opened this issue May 19, 2020 · 1 comment
Open

Switch Datepicker to Flatpickr #405

ooduor opened this issue May 19, 2020 · 1 comment
Milestone

Comments

@ooduor
Copy link
Contributor

ooduor commented May 19, 2020

Would like to suggest switch to Flatpicker (see https://flatpickr.js.org/examples/) as the date, datetime and also time picker. It seems to stable project to rely on has a lot of features that could be made optional or limited just to those three functionalities. I have already integrate it as custom deform widget elsewhere and would be happy to contribute if this is a welcome switch.

@ooduor ooduor changed the title Switch to Flatpickr Switch Datepicker to Flatpickr May 19, 2020
@stevepiercy
Copy link
Member

stevepiercy commented May 19, 2020

@ooduor that is nice. Looks good on Chrome, Firefox, Safari, Brave, and Opera. On mobile the native datetime picker is nice. I have not tried IE/Edge.

I found a bug. Click on a datetime picker and note that the time selector appears only on the second click or by tapping the arrow keys enough times. That's not a deal breaker, but it should not do that. (EDIT: actually you have to click a date first, then the time appears.)

This is an improvement over the existing datetime pickers.

The fact that it does not depend on jQuery or Bootstrap is a good thing, I guess. The UI will not align exactly with Bootstrap, but it's close enough not to matter. It could even encourage folks to try Material-UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants