Some fields aren't changed while editing #63

anna-otrokhova · 2017-11-17T16:18:55Z

We have noticed several issues which can’t be resolved within the web development.
We would greatly appreciate it if you kindly check it and give some feedback on this matter.
dev box:

Procedure Plugin - when we edit the elements in this heading the fields
performer and procedureTerminology aren’t changed.

Here is the request example:
Here is the PUT request:: http://prntscr.com/hbnnk9
We got in response: http://prntscr.com/hbnoyn
Here is the server response to GET request for the info, which was updated: http://prntscr.com/hbnot2
Here is the log:
http://prntscr.com/hbnrfz
(Hope I understood this log right)
Such behavior is faced with each editing. Could you help, please?

Contacts heading - when we edit the elements in this heading the field Relationship Type is replaced with empty value. Fields RelationshipCode and RelationshipTerminology are replaced with empty values as well, though they are uneditable from web.

Here is the PUT request: http://prntscr.com/hbpboc
We got in response: http://prntscr.com/hbpbwl
Here is the server response to GET request for the info, which was updated: http://prntscr.com/hbpfpm
Here is the log: http://prntscr.com/hbpjp7

2.1) And when we create a new element the data is replaced with the default one (Key formal care worker)

Here is the PUT request:
http://prntscr.com/hbpm26
Here is the server response to GET request for the info, which was updated: http://prntscr.com/hbpmse

2.2) By the way, when we create the contact, these fields are replaced (I suppose on back end side or in DB ) with some default data http://prntscr.com/hbpn6k , but when we edit this record http://prntscr.com/hbppwh (we don’t edit these fields, as we can’t) the fields are replaced with empty values http://prntscr.com/hbpzw4 .

When we try to edit any heading and if we don’t enter any changes into existing fields, which consists of numbers only. All numbers changed their view (for ex. 11 -> 11.0)
Here is the PUT request: http://prntscr.com/hbqa2s
Here is the server response to GET request for the info, which was updated: http://prntscr.com/hbqaje
Here is the log: http://prntscr.com/hbq9ps
When we create or edit the Referrals heading the field "dateOfReferral" is taken from the field "dateCreated" , it means no matter what date we choose it will be replaced for date of creation. The question is if it is a bug or it is a custom logic.
POST request: http://prntscr.com/hcxxvc
GET request of the mentioned above element http://prntscr.com/hcxz3z
Response from the server to GET request: http://prntscr.com/hcy04k

This issue is related to that one: PulseTile/PulseTile-React-Core#70

anna-otrokhova · 2017-11-17T16:19:17Z

@robtweed

If you could have a look we would be very grateful. Thank you in advance.

anna-otrokhova · 2017-11-17T16:23:32Z

@tony-shannon
It seems I don't have permissions to add label

tony-shannon · 2017-11-17T16:37:38Z

question label added, thanks Anna

anna-otrokhova · 2017-11-27T16:24:18Z

This point was solved.

freshehr · 2017-12-03T20:29:10Z

@robtweed - Contacts issue (2.1) -As far as I can see the AQL and FLAT JSON is correct.

relationShipRoleType e.g Daughter, should map to Relationship in the UI, while Relationship Category maps to RelationshipType in the UI.

The reason this go confused was that the Social services import/UI ended up using some conflicting names.

{
  "ctx/composer_name": "Dr Tony Shannon",
  "ctx/health_care_facility|id": "999999-345",
  "ctx/health_care_facility|name": "Home",
  "ctx/id_namespace": "NHS-UK",
  "ctx/id_scheme": "2.16.840.1.113883.2.1.4.3",
  "ctx/language": "en",
  "ctx/territory": "GB",
  "ctx/time": "2016-02-24T00:11:02.518+02:00",
  "relevant_contacts_list/relevant_contacts/relevant_contact:0/individual_person/person_name/unstructured_name": "Janice Cox",
  "relevant_contacts_list/relevant_contacts/relevant_contact:0/individual_person/address/address_description": "52 simmons St, Leeds",
  "relevant_contacts_list/relevant_contacts/relevant_contact:0/individual_person/contact_details:0/comms_description": "Mobile: 045567 33452",

//Map to UI 'Relationship Type' field 
  "relevant_contacts_list/relevant_contacts/relevant_contact:0/relationship_category|code": "at0037",
//Map to UI 'Relationship' field 
  "relevant_contacts_list/relevant_contacts/relevant_contact:0/relationship_role": "Daughter",
 
 "relevant_contacts_list/relevant_contacts/relevant_contact:0/is_next_of_kin": true,
  "relevant_contacts_list/relevant_contacts/relevant_contact:0/note": "Do not call overnight."
}

Resutset ...

 "resultSet": [
        {
            "uid": "07d7fbb8-88e7-4f69-b901-38395dd36a6b::hcbox.oprn.ehrscape.com::1",
            "dateCreated": "2016-02-24T00:11:02.518+02:00",
            "notes": "Works abroad.",
            "address": "26 Barrow St, Leeds",
            "contactInformation": "012345 33452",
            "relationshipRoleType": "Son",
            "relationshipCategory": "Main informal carer",
            "relationshipCategoryTerminology": "local",
            "author": "Dr Tony Shannon",
            "name": "John Smithy",
            "next_of_kin": null,
            "relationshipCategoryCode": "at0037"
        },

I would suggest changing thew UI field names

Relationship-> Relationship/Role
Realtionship Type-> Relationship Category

to avoid further confusion.

freshehr · 2017-12-03T20:33:14Z

The problem here is that both of the fields being populated should be strings not numerics.

"clinical_notes/clinical_synopsis:0/_name|value": "SOAP Note",
"clinical_notes/clinical_synopsis:0/notes": "Some sort of note"

freshehr · 2017-12-03T22:01:06Z

It does appear that Referral date is being set automatically by Date Created.

@robtweed - you need to add this line to the FLAT JSON

  "request_for_service/referral_details/service:0/time": "2016-03-23T00:11:02.518+02:00",

as the tasget for Referral date.

i.e.

{
  "ctx/composer_name": "Dr Tony Shannon",
  "ctx/health_care_facility|id": "999999-345",
  "ctx/health_care_facility|name": "Home",
  "ctx/id_namespace": "NHS-UK",
  "ctx/id_scheme": "2.16.840.1.113883.2.1.4.3",
  "ctx/language": "en",
  "ctx/territory": "GB",
  "ctx/time": "2016-03-24T00:11:02.518+02:00",
    "request_for_service/referral_details/service_request:0/request:0/service_name": "Optometry",
    "request_for_service/referral_details/service_request:0/request:0/reason_for_request": "Deteriorating vision",
    "request_for_service/referral_details/service_request:0/request:0/reason_description": "Long-standing impaired visual acuity - getting much worse",
    "request_for_service/referral_details/service_request:0/request:0/timing": "R5/2016-10-04T21:00:00Z/P1M",
    "request_for_service/referral_details/service_request:0/request:0/timing|formalism": "timing",
    "request_for_service/referral_details/service_request:0/requestor/person_name/unstructured_name": "Tony Shannon",
    "request_for_service/referral_details/service_request:0/receiver_identifier": "3f74c2e6-2ae0-4680-b8b2-c6daec8f9309",
    "request_for_service/referral_details/service_request:0/receiver/name_of_organisation": "Ripplefields Optometry service",
    "request_for_service/referral_details/service_request:0/narrative": "Optometry",
    "request_for_service/referral_details/service:0/receiver_identifier": "3f74c2e6-2ae0-4680-b8b2-c6daec8f9309",
    "request_for_service/referral_details/service:0/time": "2016-03-23T00:11:02.518+02:00",
    "request_for_service/referral_details/service:0/ism_transition/current_state|code": "526",
    "request_for_service/referral_details/service:0/ism_transition/careflow_step|code": "at0026",
    "request_for_service/referral_details/service:0/service_name": "Optometry"
  }

The AQL is as before - this line

  b_c/time/value as dateOfState,

returns the referralDate

anna-otrokhova · 2017-12-04T11:12:09Z

Referrals editing was fixed.

anna-otrokhova · 2017-12-04T17:14:59Z

Let us check the issue 2 and 3.

anna-otrokhova · 2017-12-06T16:49:29Z

2 and 3 were fixed on React version.
These issues may be present on Angular (dev, showcase boxes)
@tony-shannon
Shall we check them on Angular versions and raise issues in case of necessity?

tony-shannon · 2017-12-07T16:57:11Z

yes please check on both, again this is why we need easy e2e testing thanks T

…

On 6 December 2017 at 16:49, anna-otrokhova ***@***.***> wrote: 2 and 3 were fixed on React version. These issues may be present on Angular (dev, showcase boxes) @tony-shannon <https://github.com/tony-shannon> Shall we check them on Angular versions and raise issues in case of necessity? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5X3AfjwIPV7hSVFFpSbgM8TDaJeH7Hks5s9sWZgaJpZM4QiRfN> .

tony-shannon added the question label Nov 17, 2017

anna-otrokhova mentioned this issue Nov 27, 2017

Some fields aren't changed while editing PulseTile/PulseTile-React-Core#70

Closed

anna-otrokhova mentioned this issue Dec 7, 2017

All Inputs should be changed to "strings" PulseTile/PulseTile-AngularJS#66

Closed

tony-shannon added this to Backlog in Ripple-Qewd Development Jan 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some fields aren't changed while editing #63

Some fields aren't changed while editing #63

anna-otrokhova commented Nov 17, 2017 •

edited

anna-otrokhova commented Nov 17, 2017

anna-otrokhova commented Nov 17, 2017

tony-shannon commented Nov 17, 2017

anna-otrokhova commented Nov 27, 2017

freshehr commented Dec 3, 2017

freshehr commented Dec 3, 2017

freshehr commented Dec 3, 2017

anna-otrokhova commented Dec 4, 2017

anna-otrokhova commented Dec 4, 2017

anna-otrokhova commented Dec 6, 2017

tony-shannon commented Dec 7, 2017 via email

Some fields aren't changed while editing #63

Some fields aren't changed while editing #63

Comments

anna-otrokhova commented Nov 17, 2017 • edited

anna-otrokhova commented Nov 17, 2017

anna-otrokhova commented Nov 17, 2017

tony-shannon commented Nov 17, 2017

anna-otrokhova commented Nov 27, 2017

freshehr commented Dec 3, 2017

freshehr commented Dec 3, 2017

freshehr commented Dec 3, 2017

anna-otrokhova commented Dec 4, 2017

anna-otrokhova commented Dec 4, 2017

anna-otrokhova commented Dec 6, 2017

tony-shannon commented Dec 7, 2017 via email

anna-otrokhova commented Nov 17, 2017 •

edited