Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from scikit-build to scikit-build-core #2139

Open
mtreinish opened this issue May 14, 2024 · 2 comments
Open

Migrate from scikit-build to scikit-build-core #2139

mtreinish opened this issue May 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mtreinish
Copy link
Member

What is the expected behavior?

The next generation of scikit-build is scikit-build-core: https://github.com/scikit-build/scikit-build-core and it looks like it'd be much easier to maintain for managing our builds of python packages. We should investigate moving qiskit-aer over to use scikit-build-core instead of scikit-build.

There is a migration guide in the documentation here: https://scikit-build-core.readthedocs.io/en/latest/migration_guide.html

CC @wshanks

@mtreinish mtreinish added the enhancement New feature or request label May 14, 2024
@doichanj doichanj self-assigned this May 21, 2024
@doichanj
Copy link
Collaborator

I have started migrating, but I found difficulty, Aer uses environment variable to define package name for qiskit-aer or qiskit-aer-gpu in setup.py

PACKAGE_NAME = os.getenv("QISKIT_AER_PACKAGE_NAME", "qiskit-aer")

I have no idea how to define multiple package name in pyproject.toml, because tool.setuptools.dynamic does not allow name

@wshanks
Copy link
Contributor

wshanks commented Jun 13, 2024

Hmm, you mention tool.setuptools.dynamic but the topic is about migrating to scikit-build-core. Can you use the regex plugin? I have not tested if it works or not for making a dynamic name:

https://scikit-build-core.readthedocs.io/en/latest/configuration.html#dynamic-metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants