Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded DKMS dependencies from qubes-video-companion #9147

Closed
tlaurion opened this issue Apr 23, 2024 · 15 comments
Closed

Remove unneeded DKMS dependencies from qubes-video-companion #9147

tlaurion opened this issue Apr 23, 2024 · 15 comments

Comments

@tlaurion
Copy link
Contributor

How to file a helpful issue

The problem you're addressing (if any)

Only tested on debian-12, but the package depends on other packages to DKMS v4l2loopback.ko kernel module already shipped by default?

The solution you'd like

Not deploy unneeded DKMS dependencies since qubes-video-companion is not contrib package but part of qubesos repos, and therefore, needed kernel module v4l2loopback.ko is already packed deployed and installed.

The value to a user, and who that user might be

Not loose time after each template kernel update to run dkms for nothing:

user@localhost:~$ sudo apt install qubes-video-companion
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  dkms gir1.2-ayatanaappindicator3-0.1 gstreamer1.0-tools libv4l2rds0 linux-compiler-gcc-12-x86 linux-headers-6.1.0-20-amd64 linux-headers-6.1.0-20-common linux-headers-amd64 linux-kbuild-6.1 v4l-utils
  v4l2loopback-dkms
Suggested packages:
  menu v4l2loopback-utils
The following NEW packages will be installed:
  dkms gir1.2-ayatanaappindicator3-0.1 gstreamer1.0-tools libv4l2rds0 linux-compiler-gcc-12-x86 linux-headers-6.1.0-20-amd64 linux-headers-6.1.0-20-common linux-headers-amd64 linux-kbuild-6.1
  qubes-video-companion v4l-utils v4l2loopback-dkms
0 upgraded, 12 newly installed, 0 to remove and 0 not upgraded.
Need to get 14.3 MB of archives.
After this operation, 67.7 MB of additional disk space will be used.
Do you want to continue? [Y/n] y
Get:1 http://HTTPS///deb.debian.org/debian bookworm/main amd64 dkms all 3.0.10-8+deb12u1 [48.7 kB]
Get:2 http://HTTPS///deb.debian.org/debian bookworm/main amd64 gir1.2-ayatanaappindicator3-0.1 amd64 0.5.92-1 [9,032 B]
Get:3 http://HTTPS///deb.debian.org/debian bookworm/main amd64 gstreamer1.0-tools amd64 1.22.0-2 [93.1 kB]
Get:4 http://HTTPS///deb.debian.org/debian bookworm/main amd64 libv4l2rds0 amd64 1.22.1-5+b2 [80.4 kB]
Get:5 http://HTTPS///deb.debian.org/debian-security bookworm-security/main amd64 linux-compiler-gcc-12-x86 amd64 6.1.85-1 [822 kB]
Get:6 http://HTTPS///deb.debian.org/debian-security bookworm-security/main amd64 linux-headers-6.1.0-20-common all 6.1.85-1 [10.0 MB]
Get:7 http://HTTPS///deb.debian.org/debian-security bookworm-security/main amd64 linux-kbuild-6.1 amd64 6.1.85-1 [1,079 kB]
Get:8 http://HTTPS///deb.debian.org/debian-security bookworm-security/main amd64 linux-headers-6.1.0-20-amd64 amd64 6.1.85-1 [1,352 kB]
Get:9 http://HTTPS///deb.debian.org/debian-security bookworm-security/main amd64 linux-headers-amd64 amd64 6.1.85-1 [1,420 B]
Get:10 http://HTTPS///deb.debian.org/debian bookworm/main amd64 v4l-utils amd64 1.22.1-5+b2 [680 kB]
Get:11 http://HTTPS///deb.qubes-os.org/r4.1/vm bookworm/main amd64 qubes-video-companion all 1.0.5-1+deb12u1 [110 kB]
Get:12 http://HTTPS///deb.debian.org/debian bookworm/main amd64 v4l2loopback-dkms all 0.12.7-2 [37.2 kB]
Fetched 14.3 MB in 0s (75.1 MB/s)              
Selecting previously unselected package dkms.
(Reading database ... 203244 files and directories currently installed.)
Preparing to unpack .../00-dkms_3.0.10-8+deb12u1_all.deb ...
Unpacking dkms (3.0.10-8+deb12u1) ...
Selecting previously unselected package gir1.2-ayatanaappindicator3-0.1.
Preparing to unpack .../01-gir1.2-ayatanaappindicator3-0.1_0.5.92-1_amd64.deb ...
Unpacking gir1.2-ayatanaappindicator3-0.1 (0.5.92-1) ...
Selecting previously unselected package gstreamer1.0-tools.
Preparing to unpack .../02-gstreamer1.0-tools_1.22.0-2_amd64.deb ...
Unpacking gstreamer1.0-tools (1.22.0-2) ...
Selecting previously unselected package libv4l2rds0:amd64.
Preparing to unpack .../03-libv4l2rds0_1.22.1-5+b2_amd64.deb ...
Unpacking libv4l2rds0:amd64 (1.22.1-5+b2) ...
Selecting previously unselected package linux-compiler-gcc-12-x86.
Preparing to unpack .../04-linux-compiler-gcc-12-x86_6.1.85-1_amd64.deb ...
Unpacking linux-compiler-gcc-12-x86 (6.1.85-1) ...
Selecting previously unselected package linux-headers-6.1.0-20-common.
Preparing to unpack .../05-linux-headers-6.1.0-20-common_6.1.85-1_all.deb ...
Unpacking linux-headers-6.1.0-20-common (6.1.85-1) ...
Selecting previously unselected package linux-kbuild-6.1.
Preparing to unpack .../06-linux-kbuild-6.1_6.1.85-1_amd64.deb ...
Unpacking linux-kbuild-6.1 (6.1.85-1) ...
Selecting previously unselected package linux-headers-6.1.0-20-amd64.
Preparing to unpack .../07-linux-headers-6.1.0-20-amd64_6.1.85-1_amd64.deb ...
Unpacking linux-headers-6.1.0-20-amd64 (6.1.85-1) ...
Selecting previously unselected package linux-headers-amd64.
Preparing to unpack .../08-linux-headers-amd64_6.1.85-1_amd64.deb ...
Unpacking linux-headers-amd64 (6.1.85-1) ...
Selecting previously unselected package v4l-utils.
Preparing to unpack .../09-v4l-utils_1.22.1-5+b2_amd64.deb ...
Unpacking v4l-utils (1.22.1-5+b2) ...
Selecting previously unselected package qubes-video-companion.
Preparing to unpack .../10-qubes-video-companion_1.0.5-1+deb12u1_all.deb ...
Unpacking qubes-video-companion (1.0.5-1+deb12u1) ...
Selecting previously unselected package v4l2loopback-dkms.
Preparing to unpack .../11-v4l2loopback-dkms_0.12.7-2_all.deb ...
Unpacking v4l2loopback-dkms (0.12.7-2) ...
Setting up linux-headers-6.1.0-20-common (6.1.85-1) ...
Setting up dkms (3.0.10-8+deb12u1) ...
Setting up linux-compiler-gcc-12-x86 (6.1.85-1) ...
Setting up gstreamer1.0-tools (1.22.0-2) ...
Setting up libv4l2rds0:amd64 (1.22.1-5+b2) ...
Setting up linux-kbuild-6.1 (6.1.85-1) ...
Setting up gir1.2-ayatanaappindicator3-0.1 (0.5.92-1) ...
Setting up linux-headers-6.1.0-20-amd64 (6.1.85-1) ...
/etc/kernel/header_postinst.d/dkms:
dkms: running auto installation service for kernel 6.1.0-20-amd64.
dkms: autoinstall for kernel: 6.1.0-20-amd64.
Setting up linux-headers-amd64 (6.1.85-1) ...
Setting up v4l2loopback-dkms (0.12.7-2) ...
Loading new v4l2loopback-0.12.7 DKMS files...
dpkg: warning: version '6.6.25-1.qubes.fc37.x86_64' has bad syntax: invalid character in revision number
dpkg: warning: version '6.6.25-1.qubes.fc37.x86_64' has bad syntax: invalid character in revision number
Building for 6.6.25-1.qubes.fc37.x86_64
Building initial module for 6.6.25-1.qubes.fc37.x86_64
Done.

v4l2loopback.ko:
Running module version sanity check.
Module version  for v4l2loopback.ko
exactly matches what is already found in kernel 6.6.25-1.qubes.fc37.x86_64.
DKMS will not replace this module.
You may override by specifying --force.
depmod....
Setting up v4l-utils (1.22.1-5+b2) ...
Setting up qubes-video-companion (1.0.5-1+deb12u1) ...
Processing triggers for libc-bin (2.36-9+deb12u6) ...
Processing triggers for man-db (2.11.2-2) ...

Completion criteria checklist

(This section is for developer use only. Please do not modify it.)

@tlaurion tlaurion added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. labels Apr 23, 2024
@andrewdavidwong andrewdavidwong changed the title qubes-video-companion unneadingly deploying compiler and dkms since v4l2loopback.ko is already present? Remove unneeded DKMS dependencies from qubes-video-companion Apr 23, 2024
@marmarek
Copy link
Member

That dkms is needed if you use in-qube kernel, instead of dom0-provided one. Unfortunately, it isn't possible to set package dependencies related to which kernel is running (but even then, it probably won't be enough, as template may use different kernel than qubes based on it).

@marmarek
Copy link
Member

Maybe a better approach would be to drop the dependency, but document that if one wants to use in-qube kernel, then extra package (v4l2loopback-dkms) is needed?

@tlaurion
Copy link
Contributor Author

@marmarek as you see fit!

@qubesos-bot
Copy link

Automated announcement from builder-github

The component video-companion (including package qubes-video-companion-1.0.7-1.fc32) has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package video-companion has been pushed to the r4.3 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-video-companion_1.0.7-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component video-companion (including package video-companion) has been pushed to the r4.3 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.3-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package video-companion has been pushed to the r4.3 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing trixie-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component video-companion (including package video-companion) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package video-companion has been pushed to the r4.1 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component video-companion (including package video-companion) has been pushed to the r4.3 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.3-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component video-companion (including package video-companion) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package video-companion has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component video-companion (including package video-companion) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component video-companion (including package video-companion) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment